Bug 447191 - Inconsistent tooltip for ‘Target Size’ in WebP export dialogue
Summary: Inconsistent tooltip for ‘Target Size’ in WebP export dialogue
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: File formats (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-18 17:07 UTC by Karl Ove Hufthammer
Modified: 2022-05-25 01:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Ove Hufthammer 2021-12-18 17:07:06 UTC
SUMMARY
In the advanced tab of the export WebP dialogue, the tooltip for ‘Target size‘ currently says:

    If non-zero, sets the desired target size in bytes.
    Takes precedence over the compression parameters.

But the input field has a kB suffix, i.e., it sets the size in *kilobytes*, not bytes.


STEPS TO REPRODUCE
1. File → Save As … → WebP image → Advanced.
2. Hover over the ‘Target Size’ input field.

OBSERVED RESULT
If non-zero, sets the desired target size in bytes.

EXPECTED RESULT
If non-zero, sets the desired target size in kilobytes.
*or* (I prefer this one)
If non-zero, sets the desired target file size.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20211215
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.2
Comment 1 Ahab Greybeard 2021-12-22 12:29:03 UTC
I can Confirm this for the Dec 21 5.1.0-prealpha (git 32d2ca3) appimage on Debian 10.
Comment 2 amyspark 2022-05-25 01:03:28 UTC
Git commit d254583080520760f8347f1ea03d70f3cce423dc by L. E. Segovia.
Committed on 25/05/2022 at 01:00.
Pushed by lsegovia into branch 'master'.

Fix suffix of "target size" in WebP

M  +1    -1    plugins/impex/webp/dlg_webp_export.ui

https://invent.kde.org/graphics/krita/commit/d254583080520760f8347f1ea03d70f3cce423dc
Comment 3 amyspark 2022-05-25 01:04:08 UTC
Git commit 1cd2377ce4d521c8da80d025b531650afad20baa by L. E. Segovia.
Committed on 25/05/2022 at 01:03.
Pushed by lsegovia into branch 'krita/5.0'.

Fix suffix of "target size" in WebP
(cherry picked from commit d254583080520760f8347f1ea03d70f3cce423dc)

M  +1    -1    plugins/impex/webp/dlg_webp_export.ui

https://invent.kde.org/graphics/krita/commit/1cd2377ce4d521c8da80d025b531650afad20baa