Bug 447146 - Unnecessary extra margin added around pages
Summary: Unnecessary extra margin added around pages
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-17 20:10 UTC by Nate Graham
Modified: 2022-01-27 15:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Extra margin (807.39 KB, image/png)
2021-12-17 20:10 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-12-17 20:10:11 UTC
Created attachment 144632 [details]
Extra margin

Sometime in the last few months, all System Monitor pages gained extra margins around their contents. This can be hard to notice and doesn't look that bad for pages where all items are framed or floating, like the Overview and History pages. But it is very noticeable for table-style pages like Processes and Applications, and it breaks the "frameless" styling of those pages. See attached screenshot.
Comment 1 Bug Janitor Service 2022-01-27 12:15:07 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/178
Comment 2 Arjen Hiemstra 2022-01-27 15:13:34 UTC
Git commit 002556583270d33f0e4a3e637b9a0bcfd9182a77 by Arjen Hiemstra.
Committed on 27/01/2022 at 12:14.
Pushed by ngraham into branch 'master'.

Set "noMargins" to true for Applications and Processes pages

The applications and processes pages show a single full-size face and
should not have margins.

M  +1    -1    src/pages/applications.page
M  +1    -1    src/pages/processes.page

https://invent.kde.org/plasma/plasma-systemmonitor/commit/002556583270d33f0e4a3e637b9a0bcfd9182a77
Comment 3 Nate Graham 2022-01-27 15:14:06 UTC
Git commit 9ec8c45c8b61808f2bf50add120e736d1e958461 by Nate Graham, on behalf of Arjen Hiemstra.
Committed on 27/01/2022 at 15:14.
Pushed by ngraham into branch 'Plasma/5.24'.

Set "noMargins" to true for Applications and Processes pages

The applications and processes pages show a single full-size face and
should not have margins.


(cherry picked from commit 002556583270d33f0e4a3e637b9a0bcfd9182a77)

M  +1    -1    src/pages/applications.page
M  +1    -1    src/pages/processes.page

https://invent.kde.org/plasma/plasma-systemmonitor/commit/9ec8c45c8b61808f2bf50add120e736d1e958461