Bug 447033 - Update version numbers give the impression one is about to downgrade
Summary: Update version numbers give the impression one is about to downgrade
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (interactive) (show other bugs)
Version: 5.23.4
Platform: Manjaro Linux
: HI normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
: 447361 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-12-15 16:38 UTC by Natetronn
Modified: 2022-01-07 16:27 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23.5


Attachments
Screenshot of backwards version numbers for updates (43.34 KB, image/png)
2021-12-15 16:38 UTC, Natetronn
Details
How it is now (112.60 KB, image/png)
2021-12-17 03:42 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Natetronn 2021-12-15 16:38:27 UTC
Created attachment 144578 [details]
Screenshot of backwards version numbers for updates

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Open Discover
2. Click on Updates
3. Notice version numbers are backwards - See image attachment for more context

OBSERVED RESULT
This is a UI "bug".
The arrows between versions are giving off the impression that one is about to downgrade, not upgrade. 

EXPECTED RESULT
The latest (new) version should be on the right and the current should be on the left, instead. So, updating from current version number → to new version number, as we read from left to right (unless rtl language.) 

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Kernel Version: 5.15.6-2-MANJARO (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Please see attachment
Comment 1 Nate Graham 2021-12-15 17:20:30 UTC
Confirmed.
Comment 2 Aleix Pol 2021-12-17 01:30:18 UTC
Git commit 0fa8b5b2f0608b80185708e922d13afb79347ec9 by Aleix Pol.
Committed on 17/12/2021 at 01:29.
Pushed by apol into branch 'master'.

flatpak: Properly fetch the version we are upgrading to

M  +3    -0    libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
M  +2    -3    libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
M  +5    -0    libdiscover/backends/FlatpakBackend/FlatpakResource.h

https://invent.kde.org/plasma/discover/commit/0fa8b5b2f0608b80185708e922d13afb79347ec9
Comment 3 Aleix Pol 2021-12-17 01:34:20 UTC
Git commit 01cd6a0f9a1bb54959488b43d0a8047946308208 by Aleix Pol.
Committed on 17/12/2021 at 01:33.
Pushed by apol into branch 'Plasma/5.23'.

flatpak: Properly fetch the version we are upgrading to

M  +3    -0    libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
M  +2    -3    libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
M  +6    -0    libdiscover/backends/FlatpakBackend/FlatpakResource.h

https://invent.kde.org/plasma/discover/commit/01cd6a0f9a1bb54959488b43d0a8047946308208
Comment 4 Nate Graham 2021-12-17 03:42:52 UTC
Created attachment 144617 [details]
How it is now

With that commit, this is better, but still doesn't seem quite right to me. I'm attaching a screenshot. Aleix, is this the expected state?

In particular, "(21.08) -> 21.08" seems weird to me.
Comment 5 Natetronn 2021-12-17 03:50:58 UTC
I'll check it out again next time I have some updates. But based on your image, Update to version 21.08.5 (21.08) seems to make sense to me.

Yes, that does seem odd. Doesn't quite seem like anything to update if both version are the same, does it?
Comment 6 Nate Graham 2022-01-04 15:22:14 UTC
The issue with the version numbers making it look like you're about to downgrade is fixed, but there's still another issue with the numbers not being right. See Bug 447937.
Comment 7 Nate Graham 2022-01-07 16:27:32 UTC
*** Bug 447361 has been marked as a duplicate of this bug. ***