Bug 446954 - KisResourceServer has an observer pattern, but these might not work.
Summary: KisResourceServer has an observer pattern, but these might not work.
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: Resource Management (show other bugs)
Version: 5.0.0-beta2
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-13 22:09 UTC by wolthera
Modified: 2022-09-14 08:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description wolthera 2021-12-13 22:09:22 UTC 
SUMMARY
When I was trying to fix a bug with the brush preset history, I noticed that the observer pattern used by KisResourceServer doesn't work, because everything updates resources via KisResourceModel, and KisResourceModel never informs KisResourceServer, which in turn cannot inform it's observers.

I am making a bugreport for this, because I don't think it has high priority to fix right away, but it's still kinda there...
Comment 1 Dmitry Kazakov 2021-12-14 06:40:02 UTC 
I guess the idea was to remove KisResourceServer completely in the end and replace it with either KisResourceModel or KisResourcesInterface.
Comment 2 Halla Rempt 2021-12-14 07:52:23 UTC 
Yes, in the end, KoResourceServer should be gone, but it's used in so many places. This should be fixed, though, since there are still three observers.
Comment 3 Bug Janitor Service 2021-12-16 11:23:22 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1241