Bug 446909 - Scrolling over the volume slider has become painfully slow
Summary: Scrolling over the volume slider has become painfully slow
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: 21.12.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-12-13 02:02 UTC by Nagy Tibor
Modified: 2021-12-14 20:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 21.12.1
Sentry Crash Report:


Attachments
Volume slider speed comparison (Tray widget/Elisa) (363.93 KB, video/mp4)
2021-12-13 02:02 UTC, Nagy Tibor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nagy Tibor 2021-12-13 02:02:26 UTC
Created attachment 144494 [details]
Volume slider speed comparison (Tray widget/Elisa)

SUMMARY
This is a regression introduced in Elisa 21.12.0. Scrolling over the volume slider used to step the volume at around 5-10 percent increments. After the latest update the step size looks like has become 1 percent, making Elisa's volume slider painfully slow to use with the mouse wheel.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 2 Nate Graham 2021-12-14 19:50:33 UTC
Can confirm. I wonder what happened. Will investigate.
Comment 3 Nate Graham 2021-12-14 19:57:15 UTC
Yep, that commit removed `stepSize: 5`, to get the slider to stop displaying tickmarks. In so doing, it made the scroll speed 50 times slower because when `stepSize` is defined, it scrolls by increments of `stepSize, but when it's not, it scrolls in increments of 0.1!
Comment 4 Nate Graham 2021-12-14 20:11:57 UTC
Git commit 9e7cc16a869c976a9e9cca0e62eb7949f2b702ad by Nate Graham.
Committed on 14/12/2021 at 20:08.
Pushed by ngraham into branch 'release/21.12'.

Fix volume slider scroll speed regression

We stopped setting its `stepSize` property which caused the increase()
and decrease() functions to scroll in increments of 0.1, which was 50x
slower.

This commit fixes that by using custom increase and decrease code to
match the previous behavior.
FIXED-IN: 21.12.1

M  +9    -2    src/qml/VolumeSlider.qml

https://invent.kde.org/multimedia/elisa/commit/9e7cc16a869c976a9e9cca0e62eb7949f2b702ad