Bug 446716 - Inconsistent padding and alignment in the page
Summary: Inconsistent padding and alignment in the page
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: Quick Settings (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-09 08:13 UTC by Raghavendra kamath
Modified: 2021-12-09 15:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24
Sentry Crash Report:


Attachments
screenshot with anotations (160.44 KB, image/png)
2021-12-09 08:13 UTC, Raghavendra kamath
Details
screenshot of the tooltip (75.98 KB, image/png)
2021-12-09 08:13 UTC, Raghavendra kamath
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Raghavendra kamath 2021-12-09 08:13:03 UTC
Created attachment 144383 [details]
screenshot with anotations

SUMMARY

The quick settings page is great and nice way to make most used setting easily accessible. However there are some layout issues. The padding is inconsistent and also alignment of one of the label is different than other label. The tool tip to explain the feedback slider also has inconsistent border padding. 

I don't know if this issue should be limited to system settings or carried over to breeze to evaluate all the inconsistencies in the theme across the Desktop. 

I am attaching a screenshot of my observation, hopefully it will help.
Comment 1 Raghavendra kamath 2021-12-09 08:13:45 UTC
Created attachment 144384 [details]
screenshot of the tooltip
Comment 2 Bug Janitor Service 2021-12-09 08:26:31 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/736
Comment 3 Nate Graham 2021-12-09 14:50:53 UTC
One issue per bug report please. :) We'll need a second bug report about the tooltip issue as the code for that lives elsewhere.
Comment 4 Fushan Wen 2021-12-09 15:00:42 UTC
Git commit 988d686b500d41aa369b9dca5410ea3bee977f1c by Fushan Wen.
Committed on 09/12/2021 at 08:23.
Pushed by ngraham into branch 'master'.

kcms/landingpage: Adjust spacings around separators to improve consistency

Currently the spacings around the two separators are inconsistent.
Assign `Kirigami.FormData.isSection` property to the second separator,
and move both separators to the end of Kirigami.FormLayout, so the
problem can be addressed.

M  +7    -15   kcms/landingpage/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/988d686b500d41aa369b9dca5410ea3bee977f1c
Comment 5 Raghavendra kamath 2021-12-09 15:03:53 UTC
@Nate Sorry, I will make a separate report for the tool tip. And also check if other tool tip have same problem
Comment 6 Nate Graham 2021-12-09 15:39:49 UTC
Git commit 45e545dfd5fa9bf8689304f282a101d1a62a584e by Nate Graham.
Committed on 09/12/2021 at 15:39.
Pushed by ngraham into branch 'master'.

kcms/landingpage: Center feedback text under slider
FIXED-IN: 5.24

M  +6    -0    kcms/landingpage/package/contents/ui/FeedbackControls.qml

https://invent.kde.org/plasma/plasma-desktop/commit/45e545dfd5fa9bf8689304f282a101d1a62a584e