SUMMARY *** NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols. See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports *** Disabling and reenabling a bundle with one of its tags selected doesn't repopulate the resource chooser completely. STEPS TO REPRODUCE 1. Select the Quiralta tag in the brush preset chooser. 2. Disable the Quiralta brush set. 3. Reenable the Quiralta brush set. OBSERVED RESULT The preset chooser is repopulated, but the combobox isn't correctly restored. EXPECTED RESULT The preset chooser is repopulated, and the combobox is correctly restored. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
Created attachment 144366 [details] Before disabling Quiralta's brush set
Created attachment 144367 [details] After disabling Quiralta's brush set
Created attachment 144368 [details] After enabling Quiralta's brush set again Check the combobox.
This is caused by KisTagChooserWidget::tagChanged being invoked with a tag value of -1, because of the storage model removing the currently selected tag. The fix is to ensure that in such cases, the tag is instead reset to "All", which is also done when it is deleted by the user. However, adding the index reset on that function triggers a big (5 sec?) hangup because of what seems is a loop or race condition between the initial signal and the re-signaling caused by the forced index reset. Halla, perhaps you know other way around it?
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1215
Git commit 0535bdd3649700c1c7e9bcb4787c068fcd896807 by L. E. Segovia. Committed on 13/12/2021 at 19:57. Pushed by lsegovia into branch 'master'. Ensure the tag is also reset on model reset M +2 -0 libs/resourcewidgets/KisTagChooserWidget.cpp https://invent.kde.org/graphics/krita/commit/0535bdd3649700c1c7e9bcb4787c068fcd896807
Git commit 67e3f8d99afd05b42da6cced90f77cb18932ef23 by L. E. Segovia. Committed on 13/12/2021 at 20:00. Pushed by lsegovia into branch 'krita/5.0'. Ensure the tag is also reset on model reset (cherry picked from commit 0535bdd3649700c1c7e9bcb4787c068fcd896807) M +2 -0 libs/resourcewidgets/KisTagChooserWidget.cpp https://invent.kde.org/graphics/krita/commit/67e3f8d99afd05b42da6cced90f77cb18932ef23