Bug 446528 - Metadata filter in metadata tab
Summary: Metadata filter in metadata tab
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Setup-Metadata (show other bugs)
Version: 7.4.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-05 18:37 UTC by herb
Modified: 2021-12-07 16:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.4.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description herb 2021-12-05 18:37:26 UTC
SUMMARY
I use digiKam 7.4.0 snapshot 5.12.2021 on a Windows 10 system.
In digiKam main window I have selected tab "Metadata" on the right side.
Here I have the options to display metadata of Exif, MakerNotes, Iptc, Xmp and Exiftool-viewer.
In each of these tabs I have a small button to select one of the following filter options:
- No Filter
- Photograph (I think the tags assigned to this filter is hardcoded inside digiKam)
- Custom: a user defined selection - done in settings dialog - which tags are shown.

STEPS TO REPRODUCE
In case of
- I have selected NO tag for Exif-metadata in the settings dialog and
- I switch from "No Filter" to "Custom"

OBSERVED RESULT
- nothing changes inside the area of displayed metadata
- BUT the selection marker switches from "No Filter" to "Custom".

For me this is confusing, because no change of displayed metadata was made.
This behaviour is identical for all metadata: Exif, Makernotes ... when switching to "Custom" (from "No Filter" or "Photograph").

EXPECTED RESULT
To not change the displayed metadata, might be a design decision;
But in this case the selection marker (a bullet point) should also not change.

The best solution (for me) would be to disable "Custom" in case of nothing is selected for this filter.

SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2021-12-05 18:43:02 UTC
This is so desired, you have to select all metadata you want to see in the custom filter.

Maik
Comment 2 Maik Qualmann 2021-12-05 18:47:44 UTC
If no metadata tags have been selected, the filter is deactivated and all are displayed.

Maik
Comment 3 herb 2021-12-05 18:57:38 UTC
Hello,

thanks for your quick replies.
I think the goal I want to reach is misunderstood.

For me it confuses the user
- when "Custom" filter is selected - but NO tag is assigned in settings
- and ALL metadata are displayed - which is "No Filter" selection for me.
  Ok, this is design decision
- BUT in this case "No Filter" should be marked with the bullet marker 

For me the error is that "Custom" is marked with the bullet.

I hope, I described my goal clear enough.
Thanks in advance
herb
Comment 4 Maik Qualmann 2021-12-06 06:59:37 UTC
Well, I already understand your problem. The custom filter does not lead to misunderstandings for the first time, see bug 370491.
I still find it unnecessary to deactivate the custom filter because it has the same setting as no filter. What if the custom filter happens to have the same settings as the photo filter? There is then no change in the metadata display when the filter is changed.
And what if the custom filter was selected and the settings are cleared, then the custom filter is grayed out but still selected. Then switching to no filter could also be confusing.

Maik
Comment 5 herb 2021-12-06 11:00:54 UTC
Hello,

thanks for your comments. But sorry Sir, I do not fully agree:
"No Filter" is all tags to be displayed.
"Photograph" is an internally defined filter.
"Custom" is an user-defined filter.

(1) Well, when "Custom" is identical to "Photograph" and when user changes from one to the other there is no change of displayed metadata; I  agree; but marked with the bullet is that filter, that has been selected by user.

(2) When in settings for "Custom" NO tag is selected, then - for my understanding - NO tag should be displayed.
OK, your design is to display all tags in that case;
For me it is a NoGo to mark "Custom" with the bullet and display ALL="No Filter".
Sorry.

Best regards
herb
Comment 6 Maik Qualmann 2021-12-06 21:33:20 UTC
Git commit 403e9dd2a6ac3e0532564765c36b35f5c441fae8 by Maik Qualmann.
Committed on 06/12/2021 at 21:32.
Pushed by mqualmann into branch 'master'.

disable custom filter action if no custom metadata tags selected
FIXED-IN: 7.4.0

M  +1    -1    NEWS
M  +15   -0    core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp
M  +15   -0    core/libs/widgets/metadata/exiv2/metadatawidget.cpp

https://invent.kde.org/graphics/digikam/commit/403e9dd2a6ac3e0532564765c36b35f5c441fae8
Comment 7 herb 2021-12-07 16:55:14 UTC
Hello,

Thanks for this correction.

Best regards
herb