Bug 446497 - Breeze GTK theme CSD (window decorations) incorrect under Wayland
Summary: Breeze GTK theme CSD (window decorations) incorrect under Wayland
Status: RESOLVED DUPLICATE of bug 449876
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.23.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-05 01:46 UTC by Ryan Reamsbottom
Modified: 2022-02-15 05:12 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot showing the behaviour under Wayland (833.28 KB, image/png)
2021-12-05 01:46 UTC, Ryan Reamsbottom
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Reamsbottom 2021-12-05 01:46:51 UTC
Created attachment 144224 [details]
Screenshot showing the behaviour under Wayland

SUMMARY
Window decorations are inconsistent under Wayland.  With X11, the circle around the checkbox is not shown on the Close button in GTK Headerbar apps, such as Firefox (with no titlebar) or other apps (including flatpak apps).  However, upon switching to Wayland, the close button circle returns, and it seems the magic that matches the GTK theme with the window decoration settings does not happen.

STEPS TO REPRODUCE
1.  Utilizing a Wayland session, set the system to use Breeze window decorations, as is default in KDE 
2.  Open a GTK app that uses Client Side Decorations (CSD), such as Firefox after removing the title bar
3.  Note how the close button has a circle around it regardless if you remove it (like the default setting for the Breeze window decorations)

OBSERVED RESULT
Window decorations have a circle around the close button, which matches the old defaults of Breeze but look inconsistent with the new defaults.

EXPECTED RESULT
GTK header bar window decorations match the window decorations in KDE, like what happens under X11.

Tested under a new user.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Tumbleweed 20211202, Linux 5.15.5-1
(available in About System)
KDE Plasma Version: 5.23.4
KDE Frameworks Version:  5.88.9
Qt Version:  5.15.2

ADDITIONAL INFORMATION
The screenshot shows a normal KDE application (systemsettings5), along with Firefox (with no title bar), and a flatpak application that uses the GNOME runtime (Fluffychat).
Comment 1 Ryan Reamsbottom 2021-12-05 01:48:09 UTC
Minor edit: I meant "X" instead of checkbox.  Circle around the "X" on the Close Button...

Thank you!
Comment 2 Nate Graham 2021-12-07 03:19:43 UTC
Cannot reproduce under git master. Jan, or Mikhail, did this already get fixed?
Comment 3 Ryan Reamsbottom 2021-12-07 17:25:48 UTC
Hey all, I was messing around with various distros and tried out Fedora Kinoite (which is Silverblue for KDE).  I wasn't able to reproduce the bug in a Wayland session, which is strange.

Fedora Kinoite
KDE Plasma version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Kernel: 5.15.6-200.fc35.x86_64
Comment 4 Ryan Reamsbottom 2021-12-11 03:29:26 UTC
Well, this has reared it's ugly head again.  This time around, it's fine on natively installed applications, but on any Flatpak that uses the Breeze GTK theme on flathub  (org.gtk.Gtk3theme.Breeze version 3.22) both Firefox and Chromium flatpaks show the circle around the close button, even on a new profile. I think the issue would just be solved if the theme was edited to not have the circle by default (since that's the default look for Breeze).  You can get around this by using a different GTK theme and matching window decorations, but I prefer to use Breeze. 

Thanks for your time.
Comment 5 William Franco Abdul Hai 2022-02-14 10:47:41 UTC
I can reproduce this on 5.24 Tumbleweed under Wayland with both natively installed apps and flatpaks.
Comment 6 Nate Graham 2022-02-15 05:12:20 UTC
> I think the issue would just be solved if the theme was edited to not have the circle by default 
In fact that was just done in Bug 449876; marking as a duplicate of that.

*** This bug has been marked as a duplicate of bug 449876 ***