Bug 446342 - Tags Drag'n'Dropped from Tag Manager not assigned correctly in Preview
Summary: Tags Drag'n'Dropped from Tag Manager not assigned correctly in Preview
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Engine (show other bugs)
Version: 7.4.0
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-01 21:16 UTC by Tom
Modified: 2022-01-07 05:27 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.4.0
Sentry Crash Report:


Attachments
Drag and Drop action of Tag to a picture (1.94 MB, image/png)
2021-12-01 21:16 UTC, Tom
Details
Result of Drag and Drop Action - tag assigned to wrong picture (1.90 MB, image/png)
2021-12-01 21:17 UTC, Tom
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom 2021-12-01 21:16:38 UTC
Created attachment 144125 [details]
Drag and Drop action of Tag to a picture

When dragging a Tag from the Tag Manager onto a single thumbnail in preview mode, the tag is not assigned to the right picture, if a) the album has 171 or more jpgs and the chosen picture is at leat number 5 in the album.

STEPS TO REPRODUCE
1. Open Preview Mode
2. Select an Album that has 171+ jpgs in it
3. Right hand side: Selection Captions -> Tags -> Tags already assigned (to quickly see if new tag is assigned)
4. Open Tag-Manager Window (Stichwortverwaltung)
5. Select a single picture in preview pane from the middle of the list. Select only one picture - no multi-selection.
6. Drag and drop a tag from the Tag Manager onto a single picture's thumbnail (in preview mode)
7. Select "Assign Tags to this item"

No grouping of pictures done in the selected Album.

OBSERVED RESULT
Tag is assigned not to the selected (drag'n'drop target) jpg, but to anoter one. Mostly 3 or 4 pictures further down the list, sometimes also 2 or 3 before in line. 


EXPECTED RESULT
Picture on which the tag was dropped should get the tag assigned.


SOFTWARE/OS VERSIONS
macOS: 

ADDITIONAL INFORMATION
- For the first 3 pictures (from left to right, so the first three pictures in the pane) the tag assignment works as expected. Problem starts with picture 4.
- Problem seems to occur only if there are at leat a 170 pictures in the selected album
- Drag'n'Drop assignment works fine, if several thumbnails are selected before drop of tag
- Problem only occurs in Preview, not in Thumbnails-View
Comment 1 Tom 2021-12-01 21:17:12 UTC
Created attachment 144126 [details]
Result of Drag and Drop Action - tag assigned to wrong picture
Comment 2 Maik Qualmann 2021-12-01 21:47:48 UTC
I think it was never really intended to put any tags in the reduced thumbnail bar in the previews. The thumbnail bar is actually just an image selector. Tags assigning to the preview works.

Maik
Comment 3 Tom 2021-12-01 21:56:21 UTC
(In reply to Maik Qualmann from comment #2)
> I think it was never really intended to put any tags in the reduced
> thumbnail bar in the previews. The thumbnail bar is actually just an image
> selector. Tags assigning to the preview works.
> 
> Maik

Honestly, it is quite practical in this view, especially if you need to see the picture itself in a larger view than only the thumbnail in order to see details on the picture. 
If this functionality was never intended, I would wish to disable tag assignment in this view. It took me a while to find out that it assigned the tags to the wrong pictures and I had to do a bit of nasty cleanup afterwards
Comment 4 Maik Qualmann 2021-12-03 11:42:37 UTC
Git commit ced6c0dbc7347902248326222cb1615bcfddd46d by Maik Qualmann.
Committed on 03/12/2021 at 11:41.
Pushed by mqualmann into branch 'master'.

fix dropping tags on the preview thumbnail bar
FIXED-IN: 7.4.0

M  +1    -1    NEWS
M  +9    -1    core/app/dragdrop/itemdragdrop.cpp

https://invent.kde.org/graphics/digikam/commit/ced6c0dbc7347902248326222cb1615bcfddd46d