Bug 446338 - The status bar does not show the brush preset with a new or switched document
Summary: The status bar does not show the brush preset with a new or switched document
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-12-01 20:02 UTC by Ahab Greybeard
Modified: 2021-12-17 13:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahab Greybeard 2021-12-01 20:02:27 UTC
SUMMARY
This happens for all appimages from 5.0.0-beta2 onwards but does not happen for 5.0.0-beta1.
I've also tested with Windows portable .zip packages.
Hence regression wrt 5.0.0-beta-1.

Also note, that I do not see any aspects of https://bugs.kde.org/show_bug.cgi?id=441751 when testing 5.0.0-beta1.

STEPS TO REPRODUCE
1. Create a New document or open an existing .kra file and draw.
2. Select a different brush preset.
3. Create another New document or open another existing .kra file and draw.
4. Select a different brush preset.
5. Switch to the first document and draw.
6. Select a different brush preset.
7. Select a different painting tool, such as line tool or rectangle tool.
8. Select a different brush preset.

OBSERVED RESULT
1. The status bar does not show the current brush preset even if you draw on the canvas.
2. The status bar shows the newly selected brush preset any any further selected presets.
3. Same as 1.
4. Same as 2.
5. Same as 1.
6. Same as 2.
7. Same as 1.
8. Same as 2.

EXPECTED RESULT
The status bar should show the name of the brush preset at all times that a 'painting' tool is in use.

SOFTWARE/OS VERSIONS
Krita

 Version: 5.1.0-prealpha (git 7b659b3)
 Languages: en_GB, en, en, en_GB, en
 Hidpi: false

Qt

  Version (compiled): 5.12.12
  Version (loaded): 5.12.12

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 4.19.0-18-amd64
  Pretty Productname: Debian GNU/Linux 10 (buster)
  Product Type: debian
  Product Version: 10
  Desktop: MATE
Comment 1 Lynx3d 2021-12-07 12:48:27 UTC
It pretty sure is a regression from "Set the current preset on the statusbar from KisPaintOpBox" to fix bug 441751.

When switching canvas, tools get pretty much completely reset, and part of that  is clearing the status text on deactivation.

I tried to understand what "Doing so from the canvas resource managers runs into the signal
rate limiter." means, but I can't find anything that would limit the update rate from KoCanvasResourceManager => KoToolManager => KisStatusBar.
Comment 2 Dmitry Kazakov 2021-12-17 13:53:05 UTC
Git commit fa8f5cdf275db9160339d39272287652422f04dc by Dmitry Kazakov.
Committed on 17/12/2021 at 13:52.
Pushed by dkazakov into branch 'master'.

Revert "Set the current preset on the statusbar from KisPaintOpBox"

This reverts commit 9202fb2d4e07dfbe5dcd8f005159014ce3df13ea.

The original bug this commit fixed seem to have been caused by some
slow loading of the resources, which is now fixed. And the commit
itself introduces status bar update bugs.
Related: bug 441751

M  +0    -4    libs/ui/kis_paintop_box.cc
M  +0    -5    libs/ui/kis_statusbar.cc
M  +0    -2    libs/ui/kis_statusbar.h
M  +1    -0    libs/ui/kis_zoom_manager.cc
M  +4    -0    libs/ui/tool/kis_tool.cc
M  +5    -0    libs/ui/tool/kis_tool_paint.cc

https://invent.kde.org/graphics/krita/commit/fa8f5cdf275db9160339d39272287652422f04dc
Comment 3 Dmitry Kazakov 2021-12-17 13:53:34 UTC
Git commit a41f52e52243583045786bad0833c23eef017e91 by Dmitry Kazakov.
Committed on 17/12/2021 at 13:53.
Pushed by dkazakov into branch 'krita/5.0'.

Revert "Set the current preset on the statusbar from KisPaintOpBox"

This reverts commit 9202fb2d4e07dfbe5dcd8f005159014ce3df13ea.

The original bug this commit fixed seem to have been caused by some
slow loading of the resources, which is now fixed. And the commit
itself introduces status bar update bugs.
Related: bug 441751
(cherry picked from commit fa8f5cdf275db9160339d39272287652422f04dc)

M  +0    -4    libs/ui/kis_paintop_box.cc
M  +0    -5    libs/ui/kis_statusbar.cc
M  +0    -2    libs/ui/kis_statusbar.h
M  +1    -0    libs/ui/kis_zoom_manager.cc
M  +4    -0    libs/ui/tool/kis_tool.cc
M  +5    -0    libs/ui/tool/kis_tool_paint.cc

https://invent.kde.org/graphics/krita/commit/a41f52e52243583045786bad0833c23eef017e91