Bug 446337 - KDE Connect KCM launched via system tray applet should open inside System Settings
Summary: KDE Connect KCM launched via system tray applet should open inside System Set...
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: plasmoid (other bugs)
Version First Reported In: 23.04.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Phani Pavan K
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2021-12-01 19:42 UTC by Patrick Silva
Modified: 2023-07-30 07:30 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-12-01 19:42:33 UTC
STEPS TO REPRODUCE
1. open KDE Connect KCM via KDE Connect applet in system tray
2. 
3. 

OBSERVED RESULT
KDE Connect KCM opens in a standalone window with Wayland generic icon in the title bar on Wayland session

EXPECTED RESULT
other KCMs launched via their respective applets in the system tray open inside System Settings.
The same should occur with KDE Connect KCM.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.3
Graphics Platform: Wayland
Comment 1 Nate Graham 2021-12-01 23:17:18 UTC
It would be easy enough to make the applet run KCMshell.openSystemSettings("kcm_kdeconnect.desktop"), but currently it calls out to a common C++ function, so that should be changed instead, in https://invent.kde.org/network/kdeconnect-kde/-/blob/master/core/daemon.cpp#L336.

Currently it just uses QProcess::startDetached();

BooOOoooOoOoooooooooo
Comment 2 Albert Vaca Cintora 2023-04-24 18:01:06 UTC
The standalone window is there so we can use the KCM on Windows, MacOS, Gnome... I'm not against opening System Settings as long as we have a check to only do it when running Plasma.
Comment 3 Bug Janitor Service 2023-07-28 10:23:40 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/576
Comment 4 Albert Vaca Cintora 2023-07-30 07:30:55 UTC
Git commit c5b955fe10173d390150ceeee8d15b64894fc167 by Albert Vaca Cintora, on behalf of Phani Pavan Kambhampati.
Committed on 30/07/2023 at 09:30.
Pushed by albertvaka into branch 'master'.

Changed KCM to launch in system settings

KCM used to open in a separate window, changed that behaviour to launch in system settings when launched via the plasmoid.

M  +1    -1    plasmoid/package/contents/ui/FullRepresentation.qml
M  +1    -1    plasmoid/package/contents/ui/main.qml

https://invent.kde.org/network/kdeconnect-kde/-/commit/c5b955fe10173d390150ceeee8d15b64894fc167