Bug 446136 - handle "through"
Summary: handle "through"
Status: RESOLVED FIXED
Alias: None
Product: KOpeningHours
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Volker Krause
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-26 20:10 UTC by HubMiner
Modified: 2021-12-05 11:20 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/libraries/kopeninghours/commit/9bb6be75f673f9a57b21accd7c25c285a5683f0a
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description HubMiner 2021-11-26 20:10:16 UTC 
IN: Monday through Friday 09:00 - 17:00
CURRENT: failed
OUT: Mo-Fr 09:00-17:00

Please handle "thru" the same way.
Comment 1 Volker Krause 2021-11-26 21:23:10 UTC 
"through" should be fine, there is a few clashes with expressions containing the unquoted string "drive through", but those are invalid now and will remain invalid afterwards.

"thru" is more tricky. That seems to occur more frequently as a misspelling of "thur" (non-standard abbreviation of Thursday), so accepting that would probably run the risk of mis-parsing those expressions.
Comment 2 Bug Janitor Service 2021-12-05 11:04:59 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/libraries/kopeninghours/-/merge_requests/85
Comment 3 David Faure 2021-12-05 11:20:00 UTC 
Git commit 9bb6be75f673f9a57b21accd7c25c285a5683f0a by David Faure, on behalf of Volker Krause.
Committed on 05/12/2021 at 11:17.
Pushed by dfaure into branch 'release/21.12'.

Consider "through" as alternative range separator

M  +1    -0    autotests/parsertest.cpp
M  +1    -1    src/lib/openinghourslexer.l

https://invent.kde.org/libraries/kopeninghours/commit/9bb6be75f673f9a57b21accd7c25c285a5683f0a