Bug 446021 - Logout screen button animations aren't right
Summary: Logout screen button animations aren't right
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.23.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-24 10:19 UTC by pbs3141
Modified: 2021-12-01 04:38 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pbs3141 2021-11-24 10:19:50 UTC
Description

When I zip my mouse cursor over the buttons in the logout screen too fast, their opacity jumps to zero then animates back to 0.5. The opacity should not leave the range [0.5, 1] and also shouldn't jump.

Fix

In ActionButton.qml

    https://github.com/KDE/plasma-workspace/blob/91909b577045b2e347033a557d0569238db68597/lookandfeel/contents/components/ActionButton.qml#L33

the mouseover animation uses PropertyAnimation, and says in a comment that OpacityAnimator is buggy. But in LogoutButton.qml

    https://github.com/KDE/plasma-workspace/blob/91909b577045b2e347033a557d0569238db68597/lookandfeel/contents/logout/LogoutButton.qml#L27

the mouseover animation is still using OpacityAnimator. Changing it to PropertyAnimation fixes the bug for me.
Comment 1 Nate Graham 2021-11-24 17:44:33 UTC
Can confirm.
Comment 2 Nate Graham 2021-12-01 04:38:16 UTC
Git commit 747076d71262bea04c9ee9d2b971ed7b36141b23 by Nate Graham.
Committed on 01/12/2021 at 04:37.
Pushed by ngraham into branch 'master'.

LogoutButton: fix janky animation

Use a PropertyAnimation instead of an OpacityAnimator, as ActionButton
itself does. This fixes weird animation jumpiness on hover.
FIXED-IN: 5.24

M  +1    -1    lookandfeel/contents/logout/LogoutButton.qml

https://invent.kde.org/plasma/plasma-workspace/commit/747076d71262bea04c9ee9d2b971ed7b36141b23