Bug 445786 - Remove all-days range
Summary: Remove all-days range
Status: REPORTED
Alias: None
Product: KOpeningHours
Classification: Applications
Component: normalization (other bugs)
Version First Reported In: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-20 03:49 UTC by HubMiner
Modified: 2021-12-08 02:08 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description HubMiner 2021-11-20 03:49:02 UTC
Su-Mo
Mo-Su

1. This day range notation is cosmetic and can be probably removed in 100% of the cases.  
2. To minimize bothering people who don't like style changes, perhaps that should be suggested only when there are other corrections for OH value, for example:
Mo-Su 09:00-17:00 -> 09:00-17:00 (valid, don't change)
Mo-Sun 09:00-17:00; -> 09:00-17:00 (do change - other meaningful corrections were made)
Comment 1 David Faure 2021-12-05 11:48:01 UTC
You meant "Su" rather than "Sun" in your last example, right?

I agree about minimizing unnecessary style changes, that's why we have normalizedExpression() and simplifiedExpression().

But then again, when I see "09:00-17:00" I can't help but wonder if the person actually found out which days the place was open, or if that information is missing. When I see "Mo-Su 09:00-17:00" then I'm reassured that the person found out that it was open every day.

So I'm actually in favour of keeping Mo-Su or Su-Mo.
Comment 2 HubMiner 2021-12-08 02:08:26 UTC
Looks like we are going into human psychology with this topic.  :)

Based on my current OH correction experiences, I see many compound rules, for example:
 IN: Mo-Su 10:00-13:00; Mo-Su 14:00-20:00
OUT: Mo-Su 10:00-13:00,14:00-20:00
but perhaps day specifier is reassuring to have here as well.
I guess let's skip this.