Bug 445755 - Touching a window in the effect closes it rather than activating it
Summary: Touching a window in the effect closes it rather than activating it
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-overview (other bugs)
Version First Reported In: git master
Platform: Other Linux
: VHI major
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-11-19 15:35 UTC by Nate Graham
Modified: 2021-11-25 10:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-11-19 15:35:20 UTC
Everything from git master, inclusing https://invent.kde.org/plasma/kwin/-/merge_requests/1663


STEPS TO REPRODUCE
1. Activate the effect
2. Touch a window to activate it


OBSERVED RESULT
The effects ends, but the touched window is closed (!)


EXPECTED RESULT
The effect ends and the touched window is activated


Clicking does not have this effect; only touch activation closes the window instead of activating it. Perhaps the close button is unexpectedly getting focus?
Comment 1 Thiago Sueto 2021-11-21 08:21:16 UTC
Can confirm.

Interestingly enough, apps are indeed closing, not crashing. No logs are produced and they terminate cleanly.
Comment 2 Bug Janitor Service 2021-11-24 14:11:58 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1709
Comment 3 Arjen Hiemstra 2021-11-25 10:55:11 UTC
Git commit dda45a7829159494783ce5a13b11c673eeebdb8f by Arjen Hiemstra.
Committed on 25/11/2021 at 10:54.
Pushed by ahiemstra into branch 'master'.

Overview: Only trigger middle click  close with mouse/pen

For some reason, while touch doesn't have a middle button, the
taphandler for middle click close still triggered on tap. So make it
explicitly only support mouse/pen so we exclude touch events.

M  +1    -0    src/effects/overview/qml/WindowHeap.qml

https://invent.kde.org/plasma/kwin/commit/dda45a7829159494783ce5a13b11c673eeebdb8f