Bug 445643 - Store path to current POTD image in in its config file to enable various useful purposes for other software
Summary: Store path to current POTD image in in its config file to enable various usef...
Status: CONFIRMED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Picture of the Day (show other bugs)
Version: 5.23.3
Platform: Manjaro Linux
: NOR wishlist
Target Milestone: ---
Assignee: Guo Yunhe
URL:
Keywords:
: 476954 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-11-17 11:24 UTC by jan.claussen10
Modified: 2023-11-14 10:57 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jan.claussen10 2021-11-17 11:24:49 UTC
SUMMARY
The module doesn't harmonize with Latte dock, because Latte uses the current picture to paint its icons. The picture of the day module requires to set a background color, which is then used by Latte to determine the color of the wallpaper and thus breaks Latte's ability to automatically adjust itself. 

STEPS TO REPRODUCE
1. Install Latte dock and configure icon painting
2. Use "Picture of the Day" module

OBSERVED RESULT
Icons are not painted according to the picture, but to the background color set.

EXPECTED RESULT
Icons should be painted according to the picture.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.23.0
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Comment 1 Nate Graham 2021-11-23 21:18:52 UTC
Seems like a bug in Latte Dock.
Comment 2 Michail Vourlakos 2021-11-24 06:01:50 UTC
(In reply to Nate Graham from comment #1)
> Seems like a bug in Latte Dock.

no it isnt, Plasma does not provide a way to inform others what image is painting. Latte is doing its own heuristics and also it provides its own dbus API if others want to inform Latte what background they are painting. This is how https://github.com/psifidotos/latte_slideshow_wallpaper succeeds in this and others wallpaper plugins do not.

Latte based on the plasma-appletsrc config file tracks changes only for color and image file plugins nothing else because it can not find them in them plasma-appletrc file.
Comment 3 Nate Graham 2021-11-24 06:11:19 UTC
So what does Plasma need to do exactly?
Comment 4 Michail Vourlakos 2021-11-24 15:36:27 UTC
(In reply to Nate Graham from comment #3)
> So what does Plasma need to do exactly?

Solution 1: Solve this for all cases with: https://phabricator.kde.org/T13037
Solution 2a: The "Picture of Day" plugin will write in its settings file the path of the current drawn picture of the day
Solution 2b: The "Picture of Day" plugin will write in its settings file  the main background color for the current drawn picture so Latte afterwards will decide what is the best contrasted text to use; light or dark.
Comment 5 Michail Vourlakos 2021-11-24 15:42:10 UTC
Solution 3: use a dbus call to inform Latte what is the image path of the current drawn background like latte slideshow is already doing: https://github.com/psifidotos/latte_slideshow_wallpaper/blob/master/contents/ui/LatteTracer.qml#L60
Comment 6 Nate Graham 2021-11-24 20:48:40 UTC
Solution 1 seems like the best to me, but also exposing the path to the current POTD wallpaper somewhere feels reasonable. Let's make this bug report about that, since https://phabricator.kde.org/T13037 seems to have gotten stuck
Comment 7 jan.claussen10 2021-11-25 10:23:48 UTC
Great that this is getting in motion!
Comment 8 jan.claussen10 2022-06-17 06:12:21 UTC
Since Plasma can now correctly adjust its accent hue to the POTD image, shouldn't it be able to easily fix this?
Comment 9 Michail Vourlakos 2022-06-17 06:27:14 UTC
(In reply to jan.claussen10 from comment #8)
> Since Plasma can now correctly adjust its accent hue to the POTD image,
> shouldn't it be able to easily fix this?

no it isnt related, accent color has nothing to do with per screen edge - brightness level.
Comment 10 jan.claussen10 2022-06-17 10:04:27 UTC
Ah okay. I thought that there would be at least an interface now to get the picture information. Pity, solution 2b seems so easy to implement.
Comment 11 jan.claussen10 2022-06-17 10:04:48 UTC
2a I mean
Comment 12 jan.claussen10 2022-06-17 10:13:13 UTC
I think there would be a solution, altough kind of a hacky one. The current picture urls are written into /home/user/.cache/plasma_engine_potd/ in the .json files of their providers. If you could somehow query the currently set provider, you could get the current picture. But if any filenames would change, it would easily break I guess
Comment 13 jan.claussen10 2023-11-14 10:57:51 UTC
*** Bug 476954 has been marked as a duplicate of this bug. ***