Bug 445619 - [Gmic] a random crash (rare) after calling GMIC dialog
Summary: [Gmic] a random crash (rare) after calling GMIC dialog
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: G'Mic for Krita (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Appimage Linux
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-17 00:05 UTC by David REVOY
Modified: 2021-12-15 01:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Gmic crash, calling back a windows with Fractalize, GDB Backtrace. (51.82 KB, text/plain)
2021-11-17 00:05 UTC, David REVOY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2021-11-17 00:05:47 UTC
Created attachment 143648 [details]
Gmic crash, calling back a windows with Fractalize, GDB Backtrace.

Hi,
I usually have a very high stability with Gmic plugin in Krita Plus and I use it very often. But here is a rare case where this one crashed full Krita after I called back a Fractalize filter ( Thread 1252 "GmicQt::FilterT" received signal SIGABRT ). I checked: the bug is not reproducible unfortunately, but I had a full gdb backtrace. So I copy it here in attachement, in case it is a useful one.

Krita 5 Plus; krita-5.0.0-beta2-188e619-x86_64.appimage
Kubuntu 20.04 LTS.
Comment 1 amyspark 2021-11-17 01:05:07 UTC
Summoning dtschump, this looks like a crash deep inside CImg.
Comment 2 David Tschumperlé 2021-11-18 09:53:07 UTC
The problem is that CImg 2.9.9 used for the Krita plug-in is quite old now, and many things have been added/fixed in it.
It's a bit hard to say if the issue has been fixed or not.
We are planing to release G'MIC 3.0.0 (based on CImg 3.0.0) at the end of the year, so maybe it could be nice to have a 3.0.0 version of the plug-in available for Krita, at least to be able to test it with the latest code we have?
Comment 3 Halla Rempt 2021-11-18 11:09:16 UTC
If you manage to release 3.0 before we release 5.0, we can ship that version.
Comment 4 David REVOY 2021-11-18 14:56:29 UTC
In my humble (beta-tester) opinion, GMIC 2.9.9 is a solid choice for Krita 5.0 and GMIC 3.0 can wait for 5.1.

I don't want this ticket builds any pressure on GMIC to release 3.0; and no pressure on Krita to ship this new major GMIC for the near to come 5.0.

If this crash backtrace for 2.9.9 is obsolete/unuseful for David Tschumperlé, please close this tickets.

This crash is far to be a release blocker and I want to emphasis here again this is a very *rare* crash and not easy to reproduce. I'm using Gmic at least 5 times/day minimum (color grading, phocomix smoothing, tones presets, and various patterns/degradations for the background of comic panels)  and I tested it for the past two monthes now. It's solid and stable. It's better than with the old external plugin system in 3.x and 4.x. It improved a lot the way layers input/output are managed and GMIC is available now to all Krita users by default (without requiring to install plugin and tweak the settings to link to the libs). Good job to both Krita and GMIC team on this 👍

PS: If GMIC 3.0 lands in Krita 5.0 (Krita Plus), I'll be happy to stress/test it deeply before the release, even with a short time frame.
Comment 5 amyspark 2021-12-02 00:42:43 UTC
I'm ready to package a tarball if GMIC 3 comes out in time for v5. (Branch here: https://github.com/amyspark/gmic/commits/amyspark/v3.0.0, based on today's prerelease tarball.)
Comment 6 David Tschumperlé 2021-12-02 07:31:17 UTC
G'MIC 3 probably won't be ready before January, unfortunately.
Comment 7 David Tschumperlé 2021-12-05 17:28:10 UTC
When is Krita v.5 planned ?
I think G'MIC is now almost ready for a release. I won't have time to put all the stuffs I wanted, and I'll probably run out of time for the next couple of months. So, it may be a good idea to release G'MIC 3.0.0 before Xmas then, and add stuffs later for further releases.
Comment 8 Halla Rempt 2021-12-06 10:45:48 UTC
For this month...
Comment 9 David Tschumperlé 2021-12-06 10:49:17 UTC
I'll probably release G'MIC before the mid of next week. 
Everything looks ok right now. We just have to do the usual tests (valgrind and others) to check everything is ok.
Comment 10 David Tschumperlé 2021-12-09 11:17:46 UTC
I've released G'MIC 3.0.0 today!