Bug 445551 - Missing of slash '/' to terminate the HTML Bold mode in the description text
Summary: Missing of slash '/' to terminate the HTML Bold mode in the description text
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 5.0.0-beta1
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-15 20:58 UTC by Hoang Duy Tran
Modified: 2021-11-16 10:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Image showing the <b>L<b> with the missing '/' in the ending </b> bold mode (478.88 KB, image/png)
2021-11-15 20:58 UTC, Hoang Duy Tran
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hoang Duy Tran 2021-11-15 20:58:42 UTC
Created attachment 143598 [details]
Image showing the <b>L<b> with the missing '/' in the ending </b> bold mode

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
There is a missing '/' in the ending '</b>' for the HTML tag for the text:

<b><a href="https://en.wikipedia.org/wiki/Lab_color_space">L*a*b</a></b>. <b>L<b> stands for Lightness, the <b>a</b> and <b>b</b> components represent color channels.<br/>L*a*b is a special model for color correction. It is based on human perception, meaning that it tries to encode the difference in lightness, red-green balance and yellow-blue balance. This makes it useful for color correction, but the vast majority of color maths in the blending modes do <b>not</b> work as expected here.<br/>Similarly, Krita does not support HDR in LAB, meaning that HDR images converted to LAB lose color information. This colorspace is <b>not</b> recommended for painting, nor for export, but best as a space to do post-processing in. The TRC is assumed to be the L* TRC.

in the source file 

libs/ui/widgets/kis_advanced_color_space_selector.cc



STEPS TO REPRODUCE
1. Open Krita
2. Start with a new document File->New, in the 'Dimensions' tab, press the button 'Color Space Browser'
3. Select 'L*a*b*/Alpha' for the 'Model' and read the lines after the 'Copyright: No copyright, use freely'

OBSERVED RESULT
After the letter 'L', all text are STILL in BOLD mode, due to the missing '/' to terminate the 'Bold' mode.

EXPECTED RESULT
After the letter 'L', all text are in NORMAL mode.

SOFTWARE/OS VERSIONS
macOS: 10.15.7

ADDITIONAL INFORMATION
Comment 1 Halla Rempt 2021-11-16 10:11:52 UTC
Git commit 2ef050c723cbb44d354ab999cb575d4fa9a23b81 by Halla Rempt.
Committed on 16/11/2021 at 10:11.
Pushed by rempt into branch 'master'.

Fix html

M  +1    -1    libs/ui/widgets/kis_advanced_color_space_selector.cc

https://invent.kde.org/graphics/krita/commit/2ef050c723cbb44d354ab999cb575d4fa9a23b81
Comment 2 Halla Rempt 2021-11-16 10:23:42 UTC
Git commit a34adc86cf6daf3826607b0a578fa965efc169e1 by Halla Rempt.
Committed on 16/11/2021 at 10:23.
Pushed by rempt into branch 'krita/5.0'.

Fix html
(cherry picked from commit 2f7c014b40c476713e981d4bd052857ed98f5240)

M  +1    -1    libs/ui/widgets/kis_advanced_color_space_selector.cc

https://invent.kde.org/graphics/krita/commit/a34adc86cf6daf3826607b0a578fa965efc169e1