Bug 445544 - Applications list in 'Overview' page is empty after opening/closing 'Configure columns...'
Summary: Applications list in 'Overview' page is empty after opening/closing 'Configur...
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: master
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-15 17:51 UTC by Patrick Silva
Modified: 2021-12-02 14:54 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23.4
Sentry Crash Report:


Attachments
screen recording (2.09 MB, video/webm)
2021-11-15 17:51 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-11-15 17:51:04 UTC
Created attachment 143594 [details]
screen recording

SUMMARY
Summary says it all. Please watch the attached screen recording.

EXPECTED RESULT
observed result should not occur.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 1 Bug Janitor Service 2021-11-22 11:31:47 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/172
Comment 2 David Redondo 2021-12-02 14:52:53 UTC
Git commit a96bc99a3650c3bf2e48ab1287dc779dbba87c51 by David Redondo.
Committed on 02/12/2021 at 14:51.
Pushed by davidre into branch 'master'.

ApplicationsTable: Remove unneeded ProcessSortFilterModel

ProcessSortFilterModel handles filtering pids and to which user a process
belongs over a normal QSortFilterProxyModel. In doing so it also
sets the filterKeyColumn to nameColumn in findColumns(). Note that the name
of the name columns of the process and application table is different
("name" and "appName"), so the filterKeyColumn is also set by ApplicationTableView.
However this is racey depending on when the binding is evaluated.
Since we don't need the extra features of the ProcessSortFilterModel we can use
the existing SortFilterProxyModel in charge of filtering columns (something that
the ProcessSortFilterModel also did) to also handle the row filtering.
FIXED-IN:5.23.4

M  +4    -11   src/faces/applicationstable/contents/ui/ApplicationsTableView.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/a96bc99a3650c3bf2e48ab1287dc779dbba87c51
Comment 3 David Redondo 2021-12-02 14:54:29 UTC
Git commit 50f6378144ed244b9c1cd3e325ecbe45dd7544d4 by David Redondo.
Committed on 02/12/2021 at 14:54.
Pushed by davidre into branch 'Plasma/5.23'.

ApplicationsTable: Remove unneeded ProcessSortFilterModel

ProcessSortFilterModel handles filtering pids and to which user a process
belongs over a normal QSortFilterProxyModel. In doing so it also
sets the filterKeyColumn to nameColumn in findColumns(). Note that the name
of the name columns of the process and application table is different
("name" and "appName"), so the filterKeyColumn is also set by ApplicationTableView.
However this is racey depending on when the binding is evaluated.
Since we don't need the extra features of the ProcessSortFilterModel we can use
the existing SortFilterProxyModel in charge of filtering columns (something that
the ProcessSortFilterModel also did) to also handle the row filtering.
FIXED-IN:5.23.4


(cherry picked from commit a96bc99a3650c3bf2e48ab1287dc779dbba87c51)

M  +4    -11   src/faces/applicationstable/contents/ui/ApplicationsTableView.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/50f6378144ed244b9c1cd3e325ecbe45dd7544d4