Bug 445520 - Visual bell unreliable in latest version
Summary: Visual bell unreliable in latest version
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 21.11.80
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-15 10:44 UTC by davidblunkett
Modified: 2022-06-30 16:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (92.87 KB, image/png)
2022-01-11 22:26 UTC, Kurt Hindenburg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description davidblunkett 2021-11-15 10:44:18 UTC
Having recently moved to this version the visual bell / bell notifications appear not to be working as before.

Previously I had a bell marked in the kde taskbar and bells in focused windows ring audibly.  This doesn't seem to work reliably any more and the visual bell marked in the task bar when it does work isn't very obvious (a little bell icon appears now but previously it change the taskbar colour for that entry which was much more obvious).

I've got "mark taskbar entry" and "bell in focused" checked but I guess this means the konsole tabbar not the kde taskbar? - how do I get the kde taskbar notification me now?

I've also got both marked for non focused sessions but this simply doesn't work, no bell, not konsole tab bar bell icon, no kde taskbar bell icon?

I wouldn't be surprised if I've missed something but I can't see what it might be and it is definitely different from the previous incarnation!
Comment 1 gi1242 2021-12-11 23:48:33 UTC
I think the problem is a regression between versions 21.08.3-1 and 21.11.80-1 (and is still present in 21.12.0-1).

Simple test: Run

    echo -n "\e]11;#004000\a"

In other terminal emulators (xterm), and konsole 21.08.3-1 and earlier, the background goes green. In Konsole 21.11.80-1 and later the background goes green only after a redraw.

My guess is that the visual bell bug is related to this, and there is a bug (regression) in the background refresh.

I'm using Arch linux.

GI
Comment 2 gi1242 2021-12-11 23:53:07 UTC
I think the problem is a regression between versions 21.08.3-1 and 21.11.80-1 (and is still present in 21.12.0-1).

Simple test: Run

    echo -n "\e]11;#004000\a"

In other terminal emulators (xterm), and konsole 21.08.3-1 and earlier, the background goes green. In Konsole 21.11.80-1 and later the background goes green only after a redraw.

My guess is that the visual bell bug is related to this, and there is a bug (regression) in the background refresh.

I'm using Arch linux.

GI

PS: I couldn't figure out how to mark it as a regression. So I just set component to general, and marked it as confirmed.
Comment 3 Bug Janitor Service 2022-01-07 23:52:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/573
Comment 4 Kurt Hindenburg 2022-01-11 16:12:35 UTC
Git commit 0fe44c52310a6c276388cf30c81b6fc45a39da32 by Kurt Hindenburg, on behalf of Luis Javier Merino Morán.
Committed on 11/01/2022 at 15:57.
Pushed by hindenburg into branch 'master'.

Pass widget again to KNotification on bell

67508680 refactored TerminalBell out from TerminalDisplay, and in the
process stopped passing the TerminalDisplay widget to KNotification,
which resulted in issues when notifications where configured to mark the
task bar entry or run a command with %w/%t substitutions (for window id
and window title).

Many thanks to Nicole Kleinhoff and Jan Palus who identified the commit
that introduced the regression.
Related: bug 443411, bug 443117

M  +3    -2    src/terminalDisplay/TerminalBell.cpp
M  +2    -1    src/terminalDisplay/TerminalBell.h
M  +1    -1    src/terminalDisplay/TerminalDisplay.cpp

https://invent.kde.org/utilities/konsole/commit/0fe44c52310a6c276388cf30c81b6fc45a39da32
Comment 5 gi1242 2022-01-11 22:10:31 UTC
This doesn't fix the problem for me! Simple test:

1. Enalble Visual Bell
2. Type 'echo -e "\a" ' into a shell

Display is borked for me (half white half black). I can share a screen cast if you can't reproduce it.
Comment 6 Kurt Hindenburg 2022-01-11 22:26:08 UTC
Created attachment 145341 [details]
screenshot
Comment 7 Bug Janitor Service 2022-01-12 16:13:07 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/579
Comment 8 ninjalj 2022-01-12 18:37:00 UTC
Git commit 2f2ae3d9bb8a44fa987c10cc4b2a9018d34f300b by Luis Javier Merino Morán.
Committed on 12/01/2022 at 16:19.
Pushed by hindenburg into branch 'master'.

Fix visual bell

Changes to scrollbar colouring interfered with the visual bell.
TerminalColor::onColorsChanged() not only updates the scrollbar palette
(for Breeze widget style), but also updates the TerminalDisplay palette.

M  +6    -0    src/terminalDisplay/TerminalColor.cpp

https://invent.kde.org/utilities/konsole/commit/2f2ae3d9bb8a44fa987c10cc4b2a9018d34f300b