Bug 445444 - wrong window size for alacritty terminal emulator
Summary: wrong window size for alacritty terminal emulator
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: wayland-generic (show other bugs)
Version: 5.23.3
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-11-13 21:13 UTC by Matthew Cohen
Modified: 2021-12-08 18:54 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23.4


Attachments
The output of `WAYLAND_DEBUG=1 alacritty` (25.37 KB, text/x-log)
2021-11-16 15:43 UTC, Vasil Yonkov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Cohen 2021-11-13 21:13:19 UTC
SUMMARY

A recent Plasma upgrade made it so terminal emulator alacritty gets incorrectly resized to a 2x1 window when opened.

I opened a bug report with alacritty and they said this is a KDE issue, so I'm reporting it here. I have not seen this resize bug effect other programs outside of alacritty.

Github issue - https://github.com/alacritty/alacritty/issues/5603

STEPS TO REPRODUCE
1. open alacritty

OBSERVED RESULT

alacritty window is tiny (2x1)

EXPECTED RESULT
alacritty window is size specified in config file (behavior even occurs if config file is deleted and default setting is used)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma

KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2
Comment 1 Chang Liu 2021-11-14 04:11:39 UTC
I got the same issue for kwin-5.23.3. Downgrading kwin to 5.22 can solve this issue temporarily.
Comment 2 Chang Liu 2021-11-14 04:12:36 UTC
Typo. Downgrading to kwin 5.23.2 can solve this issue.
Comment 3 Vasil Yonkov 2021-11-16 11:21:44 UTC
I'm using the same versions of KDE/QT/Alacritty on ArchLinux and I'm having the same issue.
Comment 4 Vasil Yonkov 2021-11-16 15:23:56 UTC
I've bisected the commits between 5.23.2 and 5.23.3 and identified this one as the culprit - https://invent.kde.org/plasma/kwin/-/commit/e2f9f35c3cb07503e5ffd7b0134526ec0edddc83
Comment 5 David Edmundson 2021-11-16 15:32:52 UTC
Can you attach a log of 

WAYLAND_DEBUG=1 alacritty
Comment 6 Vasil Yonkov 2021-11-16 15:43:25 UTC
Created attachment 143633 [details]
The output of `WAYLAND_DEBUG=1 alacritty`

The output of `WAYLAND_DEBUG=1 alacritty` when kwin is built from this commit - e2f9f35c3cb07503e5ffd7b0134526ec0edddc83.
Comment 7 Bug Janitor Service 2021-11-16 20:39:02 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1674
Comment 8 David Edmundson 2021-11-17 06:48:42 UTC
first configure event is

[3085629.386] xdg_toplevel@22.configure(1, 1, array)
which shows kwin is telling it do this, which is weird. From the logs I can't see why it wouldn't be 0,0.

but the log shows something very wrong on the client.

We're committing the surface before setting min/max/deco. This needs fixing their side.
Comment 9 Vlad Zahorodnii 2021-11-17 06:58:47 UTC
Git commit 068d60e36a112c6b901010331ef3a995019c97cb by Vlad Zahorodnii.
Committed on 17/11/2021 at 06:58.
Pushed by vladz into branch 'master'.

Revert "wayland: Check workspace position when preferred deco mode changes"

This reverts commit 2560288e4b66acfdbb8a8f4daafd2d600aeb525a.

It broke alacricitty. The fix is not obvious, so revert the commit for
the time being.

M  +1    -1    src/xdgshellclient.cpp

https://invent.kde.org/plasma/kwin/commit/068d60e36a112c6b901010331ef3a995019c97cb
Comment 10 Vlad Zahorodnii 2021-11-17 06:59:18 UTC
Git commit 325208347c40d7311aea83572b5150ba3750cba9 by Vlad Zahorodnii.
Committed on 17/11/2021 at 06:59.
Pushed by vladz into branch 'Plasma/5.23'.

Revert "wayland: Check workspace position when preferred deco mode changes"

This reverts commit 2560288e4b66acfdbb8a8f4daafd2d600aeb525a.

It broke alacricitty. The fix is not obvious, so revert the commit for
the time being.


(cherry picked from commit 068d60e36a112c6b901010331ef3a995019c97cb)

M  +1    -1    src/xdgshellclient.cpp

https://invent.kde.org/plasma/kwin/commit/325208347c40d7311aea83572b5150ba3750cba9