Bug 445224 - Short date format preview not visible on Time page
Summary: Short date format preview not visible on Time page
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_regionandlang (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-11-09 19:39 UTC by Ahmad Samir
Modified: 2022-10-19 03:57 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
kcm_formats (128.39 KB, image/png)
2021-11-09 21:49 UTC, Ahmad Samir
Details
kcm_formats-2 (97.33 KB, image/png)
2021-11-10 04:26 UTC, Ahmad Samir
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Samir 2021-11-09 19:39:34 UTC
Launching `systemsettings kcm_formats` I don't see the short date format e.g.:
09-11-2021 or
09/11/2021

it used to be shown in the KCM before the recent rewrite.
Comment 1 Nate Graham 2021-11-09 21:39:16 UTC
Hmm, I see it. Can you attach a screenshot?
Comment 2 Ahmad Samir 2021-11-09 21:49:56 UTC
Created attachment 143382 [details]
kcm_formats
Comment 3 Nate Graham 2021-11-09 21:58:47 UTC
Ah, this is the old KCM, not the new one. This happened to me too after the new one was merged; you probably have the old formats.so file still lying around somewhere. If you delete it and its desktop file, you'll get the new one.
Comment 4 Ahmad Samir 2021-11-09 23:03:52 UTC
I have the new KCM, which doesn't have the date format I mentioned in the description; I posted a screenshot of the old one that has it, the current KCM doesn't
Comment 5 Nate Graham 2021-11-10 00:58:41 UTC
Oh. Can you post a screenshot of the issue in the new KCM?
Comment 6 Ahmad Samir 2021-11-10 04:26:29 UTC
Created attachment 143393 [details]
kcm_formats-2
Comment 7 Nate Graham 2021-11-10 18:48:14 UTC
Ah, I see what you mean now. The short date preview is visible on the main page (which is what I was looking at), but not on the Time page itself. Confirmed.
Comment 8 hanyoung 2021-11-11 01:21:08 UTC
I excluded short format on Time page because otherwise it's too long to fit in one line. There will be short time format examples after Language & Formats merge done.
Comment 9 Nate Graham 2021-11-11 01:23:56 UTC
Why not use two lines, like on the main page?
Comment 10 hanyoung 2021-11-11 01:26:55 UTC
(In reply to Nate Graham from comment #9)
> Why not use two lines, like on the main page?

It's implemented as trailing, so for it to properly display, the height of the ListItem must be larger than the trailing. But on PinePhone this isn't the case, resulting in trailing overlapping the next listitem. On main menu the listitem is large enough.
Comment 11 Nate Graham 2021-11-11 01:39:27 UTC
If you set `reserveSpaceForSubtitle: true` on the list items on the Time page, they will be tall enough to accommodate a two-line trailing item.
Comment 12 Ahmad Samir 2022-05-13 16:51:05 UTC
Ping.
Comment 13 hanyoung 2022-05-13 16:54:20 UTC
The short format is added back in the new Region & Language KCM: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1147
Comment 14 Ahmad Samir 2022-05-13 17:43:49 UTC
OK, thanks for the feedback.
Comment 15 hanyoung 2022-10-19 03:57:42 UTC
The short format is added back in the new Region & Language KCM, and the new KCM has replaced both Language and Formats KCM in Plasma 5.26