Bug 445177 - kcm.push with title doesn't use title
Summary: kcm.push with title doesn't use title
Status: CONFIRMED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR minor
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-08 21:27 UTC by postix
Modified: 2021-11-16 14:04 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (99.87 KB, image/png)
2021-11-08 21:27 UTC, postix
Details
Screenshot: Detailed Info button (529.13 KB, image/png)
2021-11-09 14:35 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2021-11-08 21:27:51 UTC
Created attachment 143350 [details]
Screenshot

I think it'd make more sense to call it `Storage Device Health Monitoring > Detailed Information` or shorter `Storage Device Health Monitoring > Details`.


SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20211106
KDE Plasma Version: 5.23.2
KDE Frameworks Version: 5.87.0
Comment 1 Nate Graham 2021-11-09 04:18:03 UTC
How did you get to the details page? I can't see how to.
Comment 2 postix 2021-11-09 09:57:27 UTC
(In reply to Nate Graham from comment #1)
> How did you get to the details page? I can't see how to.

1) Open Info Center
2) Click in section "Detailed Information" on "Devices"
3) Click on "SMART Status"
4) Pick on of your drives and click on "Detailed Information"
Comment 3 Nate Graham 2021-11-09 14:32:53 UTC
Indeed, but I don't see a "Detailed information" button there.
Comment 4 postix 2021-11-09 14:35:43 UTC
Created attachment 143374 [details]
Screenshot: Detailed Info button

(In reply to Nate Graham from comment #3)
> Indeed, but I don't see a "Detailed information" button there.

You don't have this one?
Comment 5 Nate Graham 2021-11-09 14:38:20 UTC
Nope
Comment 6 postix 2021-11-09 14:52:13 UTC
Then maybe you should open a bug report. :-P(In reply to Nate Graham from comment #5)
> Nope

Me neither on Fedora 35, but it's there on openSUSE TW. It seems it's only there if there is a 'detailed report' available. [1]

```
visible: model.advancedReport !== ''
```

[1] https://invent.kde.org/plasma/plasma-disks/-/blob/master/src/kcm/package/contents/main.qml#L113
Comment 7 Harald Sitter 2021-11-15 08:03:30 UTC
Nate, that feature wasn't working for you because of your kauth setup if you recall ;)
Comment 8 Harald Sitter 2021-11-15 08:17:40 UTC
Strange bug somewhere in the stack.

The page gets created thusly:

> kcm.push("ReportPage.qml", {title: product, text: advancedReport})

which should result in the correct title (and I feel like it has in the past), but the title is wrong. It only appears correct once I define the property in the ReportPage.qml

>     title: "TITLE_NOT_SET"

which will result in `product` getting used as title. 

Bouncing bug to systemsettings cause I don't know where exactly the problem is so next level down in the stack seems as good a fit as any.

Also happens with the more generic

> kcm.push("page.qml", {title: "foo"})