Bug 445062 - KTorrent doesn't escape HTML in torrent metadata
Summary: KTorrent doesn't escape HTML in torrent metadata
Status: CONFIRMED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (other bugs)
Version First Reported In: 21.08.3
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-06 06:43 UTC by Nagy Tibor
Modified: 2025-04-17 09:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Screenshot (460.83 KB, image/png)
2021-11-06 06:43 UTC, Nagy Tibor 		Details
Screenshot (tooltips) (491.60 KB, image/png)
2021-11-06 07:47 UTC, Nagy Tibor 		Details
Screenshot (torrent groups) (488.12 KB, image/png)
2021-11-06 11:47 UTC, Nagy Tibor 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nagy Tibor 2021-11-06 06:43:33 UTC 
Created attachment 143270 [details]
Screenshot

SUMMARY
KTorrent currently doesn't escape HTML from the torrents' comment metadata field. This is not a great idea.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.2
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 1 Nagy Tibor 2021-11-06 07:47:41 UTC 
Created attachment 143272 [details]
Screenshot (tooltips)

Torrent name tooltips are also affected by this.
Comment 2 Nagy Tibor 2021-11-06 11:47:36 UTC 
Created attachment 143278 [details]
Screenshot (torrent groups)

I know it's not metadata but the custom torrent groups feature is also plagued by this.
Comment 3 ulterno 2025-04-17 09:42:00 UTC 
Confirmed in master.

Thankfully, the places where this happens, it doesn't seem to be downloading http resources.

Problematically, the Info tab (where the comment is shown) has neither a scroll-space nor a height restriction, meaning, if you use too large a picture for testing the bug, it will cause the whole window to get out of the screen and not even maximising the window will help.

We need an "Esc" to close the bottom panels. BUG:502921

Also, while reproducing this bug in master, I came across BUG:502919