Bug 444968 - Partition Manager: tab/focus order in create new partition dialog is weird
Summary: Partition Manager: tab/focus order in create new partition dialog is weird
Status: RESOLVED FIXED
Alias: None
Product: partitionmanager
Classification: Applications
Component: general (show other bugs)
Version: 21.08.2
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Andrius Štikonas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-04 18:10 UTC by Andrei Rybak
Modified: 2021-12-05 00:01 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 22.04.0
Sentry Crash Report:


Attachments
OBSERVED RESULT -- screen recording of the weird focus change behaviour (191.75 KB, video/mp4)
2021-11-04 18:10 UTC, Andrei Rybak
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Rybak 2021-11-04 18:10:55 UTC
Created attachment 143212 [details]
OBSERVED RESULT -- screen recording of the weird focus change behaviour

SUMMARY
Navigating the modal dialog to create a new partition from keyboard is uncomfortable.

STEPS TO REPRODUCE
1. Open KDE Partition Manager
2. Select an unallocated space on any of the drives
3. Press Ctrl+N
4. Press Tab several times
5. Observe where the focus goes

OBSERVED RESULT
Focus changes in unintuitive ways. I noticed the problem when I couldn't get to the "File system" dropdown. See the screen recording -- note how sometimes, the focus goes from "Primary" radiobutton straight to "Label", skipping over "File system" dropdown and encryption checkbox.

EXPECTED RESULT
Focus change "loop" is top-to-bottom left-to-right (in English locale).

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.2
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.3
Kernel Version: 5.11.0-38-generic (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i5-8250U CPU @ 1.60GHz
Memory: 7.7 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620
Comment 1 Andrius Štikonas 2021-12-04 23:58:27 UTC
I can improve tab order a bit but it's not completely satisfactory.

With my change, it cycles as expected when Encrypt checkbox is off. However, if you enable Encrypt checkbox then password lines are only focused just before advanced/ok/cancel buttons are focused.

Still that is better than current behaviour where order is completely messed up.
Comment 2 Andrius Štikonas 2021-12-05 00:01:26 UTC
Git commit 81bbfea449e261dcafdc378e880748189a23ad63 by Andrius Štikonas.
Committed on 04/12/2021 at 23:59.
Pushed by stikonas into branch 'master'.

Improve tab focus order in create partition dialog.

M  +8    -5    src/gui/sizedialogwidgetbase.ui

https://invent.kde.org/system/partitionmanager/commit/81bbfea449e261dcafdc378e880748189a23ad63