Bug 444890 - Okular window visible on all virtual desktops ignores setting "Open new files in tabs"
Summary: Okular window visible on all virtual desktops ignores setting "Open new files...
Status: ASSIGNED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 21.08.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-03 16:53 UTC by Dominik Kummer
Modified: 2024-05-03 07:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Kummer 2021-11-03 16:53:14 UTC
In Okular settings I activated this program feature option. Trying to open several documents from within dolphin launches new instances though. I tried to add the option --unique to okular command in Fila Associations settings, but it does not help. And thats horrible, because I want to access okular with shortcut Meta+O which now does only focus the first instance. The feature did work in the past for sure, but right now I cannot recall when it stopped working.
Comment 1 Albert Astals Cid 2021-11-03 20:25:03 UTC
Did you install via pacman or flatpak?

Which desktop environment do you use?
Comment 2 Dominik Kummer 2021-11-03 20:27:58 UTC
sorry for not fully providing all requested details in my initial report!

pacman and kde
Comment 3 Albert Astals Cid 2021-11-03 23:26:09 UTC
There's something wrong with your setup, because i'm using Arch packages and it works for me.

Sadly i have no idea how to help you debug this further.
Comment 4 Dominik Kummer 2021-11-04 00:46:09 UTC
Thats good to know. 
I now moved all okular configs to backup without success.
Finally I found that the bug is related to window rules:
I defined an okular window rule placing okular on all virtual desktops initially (rule policy: apply initially).
As soon as I remove the rule, okular opens all documents in tabs again.
When I place okular on all virtual desktops forcibly (rule policy: force) the tabs feature works also!

Rule policy "apply initially" seems to be the problem here. which makes the bug really minor to me now. but eventually the bug effects other window rule use cases also.
Comment 5 Albert Astals Cid 2021-11-04 18:40:43 UTC
Window Rules are controlled by the Window Manager/Desktop Environment, so to me this would be a Plasma bug if anything.
Comment 6 Dominik Kummer 2021-11-04 20:40:58 UTC
Can you confirm the behavior I described?
Comment 7 Albert Astals Cid 2021-11-04 22:45:38 UTC
Honestly I don't even know how to use Window Rules, so I have not tried because i don't understand what you wrote in that comment other that "I used special Window Rules and it broke"
Comment 8 Dominik Kummer 2021-11-04 23:05:44 UTC
so please don't redirect me into other projects without reading the report.

I supect the issue around attachExistingInstance() in shell/okular_main.cpp. It does not understand what to do
if okular is visible on multiple virtual plasma desktops at the same time. At least that's what the
symptom looks like. Maybe it is intentional. But it does not feel like so.
Comment 9 Dominik Kummer 2021-11-04 23:07:24 UTC
i use special window rule blabla. yeah.
Comment 10 Albert Astals Cid 2021-11-04 23:44:57 UTC
Ah, ridiculing the developer, that's how you expect me to chose to prioritize your bug among the other 400 issues I can work on?

For the future, not a good idea.
Comment 11 Dominik Kummer 2021-11-04 23:52:41 UTC
why not? maintain your priorities as you wish. I dont expect to be the first one.

I just file a bug report, try to connect the dots from a user point of view, try to scratch the surface of the source code, maybe I can contribute something helpful, or probably I will debug it on my own someday.

but randomly redirecting bug reporters is no real help for anyone.
Comment 12 Albert Astals Cid 2024-05-02 17:18:12 UTC
Do not steal assignee.
Comment 13 Dominik Kummer 2024-05-03 07:35:22 UTC
As far as I am concerned tasks can't be stolen, but taken - important difference, decriminalization of colaboration etc.
Why does the interface offer this function though?