Bug 444884 - image-x-icon has a Windows logo in the middle
Summary: image-x-icon has a Windows logo in the middle
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-03 14:53 UTC by Aleix Pol
Modified: 2021-11-04 16:50 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.88
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleix Pol 2021-11-03 14:53:16 UTC
At the moment, it's the same as image-x-ico, which does make sense that it has the Windows logo in there.

This is especially important as it's what Kirigami defaults to:
https://invent.kde.org/frameworks/kirigami/-/blob/master/src/icon.h#L228
Comment 1 Christian (Fuchs) 2021-11-03 15:10:07 UTC
based on the VDG chat discussion, here so we have it here as well:

the mimetype image/x-icon is not "a generic icon" but specifically one based on the microsoft icon spec used for windows icons (and favicons in IE/Edge), so it makes sense to have a windows logo in it. Software wanting a "generic icon" graphic or icon should use that instead of the image/x-icon mimetype. If such a graphic is currently not available, it could be created. I'd recommend not changing the mimetype icon for image/x-icon.
Comment 2 Bug Janitor Service 2021-11-03 15:12:50 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/414
Comment 3 Aleix Pol 2021-11-04 12:27:57 UTC
Git commit ef1bd0b05b22f146e9555bb496c64747e63cd564 by Aleix Pol.
Committed on 03/11/2021 at 15:11.
Pushed by apol into branch 'master'.

Icon: Use icon-png as the default placeholder instead of icon-x-icon

That referred to png icons which is a bit confusing. It could make sense
to have an ad-hoc placeholder icon.

M  +1    -1    src/icon.h

https://invent.kde.org/frameworks/kirigami/commit/ef1bd0b05b22f146e9555bb496c64747e63cd564