Bug 444881 - Charcoal drawing doesn't remember previous pencil size
Summary: Charcoal drawing doesn't remember previous pencil size
Status: RESOLVED WORKSFORME
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-Charcoal (show other bugs)
Version: 7.4.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-03 13:23 UTC by maderios
Modified: 2021-11-04 14:37 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description maderios 2021-11-03 13:23:28 UTC
Conditions: Arch Linux system, build from git
Qt Version: 5.15.2
Opencv : 4.5.4
Charcoal drawing doesn't remember previous pencil size issue
STEPS TO REPRODUCE
1.  Open jpeg image in editor
2. select charcoal drawing tool
3. select custom pencil size : 11
3. apply and view result
4. open other jpeg image in editor
5. pencil size is not "11" but "32". 
This issue happens for each new image i open with editor, it always go back to "11".  Every time i need to use charcoal drawing, i have to set my custom setting again. This issue didn't happen with previous digikam versions
Comment 1 maderios 2021-11-03 13:25:50 UTC
*Mistake*
Right comment: This issue happens for each new image i open with editor, it always go back to "32".
Comment 2 Maik Qualmann 2021-11-03 14:04:33 UTC
There is an option in the digiKam settings for the Image Editor that the tool settings are not saved. Possibly activated?

Maik
Comment 3 maderios 2021-11-03 14:33:51 UTC
(In reply to Maik Qualmann from comment #2)
> There is an option in the digiKam settings for the Image Editor that the
> tool settings are not saved. Possibly activated?
Hi
Where? I didn't find it.
I just found In settings:  image editor settings, restore the settings of image editors
It is activated. If desactivate it, settings always go back to 5/ default
Comment 4 Maik Qualmann 2021-11-03 17:36:58 UTC
I cannot reproduce a problem, the last pencil size used is taken correctly.  There were no changes to this tool since the last version. Check the file rights on your "digikamrc" configuration file.

Look for this section in the "digikamrc" and check the entries for changes:

[charcoal Tool]
PencilAdjustment=11
SmoothAdjustment=10

Maik
Comment 5 maderios 2021-11-03 17:54:48 UTC
I set PencilAdjustment=11 in digikamrc then, i had to restart digikam to get this pencil size setting remembered by Digikam. With previous Digikam versions, i didn't have to edit manually digikamrc to remember pencil size setting. I just did it on editor right side. For me, something has changed somewhere...
Comment 6 Maik Qualmann 2021-11-03 18:33:25 UTC
No, you shouldn't change the "digikamrc" manually. That the problem cannot be reproduced here with the GIT version, I would like to narrow down the problem for you. You should set a pencil size and quit digiKam and then check whether the value has been saved in "digikamrc". 

Maik
Comment 7 maderios 2021-11-03 19:01:24 UTC
I understand what happens now: if  do "ok" after changing pencil size, new setting is written in digikamrc. If i  only do "try", it's not written in digikamrc, new size is  only displayed in digikam. I think it was different with  previous versions. I  had to do only "try" to change pencil size setting and write it in digikamrc.
Comment 8 Maik Qualmann 2021-11-03 19:18:14 UTC
No, the configuration is definitely not saved with "Try", with no other tool and not even earlier. The configuration is only saved with "Ok" and "Cancel". 

Maik
Comment 9 Maik Qualmann 2021-11-03 19:26:59 UTC
I have tested the behavior here with an older AppImage-6.4.0, the behavior is identical. If you exit the Image Editor with the tool open, the value will not be saved. I wouldn't change anything about this behavior at the moment. 

Maik
Comment 10 Maik Qualmann 2021-11-03 21:16:39 UTC
I would only save the settings if "Ok" is used and not with "Cancel", but we leave the current behavior as it is.
Comment 11 maderios 2021-11-04 14:37:34 UTC
OK, thanks