Bug 444838 - Make mounted partitions share the same icons across Dolphin
Summary: Make mounted partitions share the same icons across Dolphin
Status: CONFIRMED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KIO Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-02 16:40 UTC by WS
Modified: 2022-02-02 16:48 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Device panel and main panel using big icons have different icons for the same thing (20.12 KB, image/png)
2021-11-02 16:40 UTC, WS
Details
Same thing with small icons (27.42 KB, image/png)
2021-11-02 16:41 UTC, WS
Details

Note You need to log in before you can comment on or make changes to this bug.
Description WS 2021-11-02 16:40:29 UTC
Created attachment 143142 [details]
Device panel and main panel using big icons have different icons for the same thing

SUMMARY

The Places panel have icons dedicated to connected devices and partitions. However, in the main panel, they are represented by a folder icon. Use the same from the Places panel to ensure consistency.

It's incredibly odd to look at Device section of Places panel, see things that are clearly marked as a partition/device, only for when you open them and "Go Up" to see an icon that represents a folder. It's inconsistent and weird. It's create a temporary confusion for new users where they are unsure if that is really a partition/device or somehow a folder with the same exact name.

I can't think of any reason against making them the same icon, after all, it's just an icon.
Comment 1 WS 2021-11-02 16:41:21 UTC
Created attachment 143143 [details]
Same thing with small icons
Comment 2 Bug Janitor Service 2021-12-12 11:33:39 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/657
Comment 3 Fushan Wen 2022-02-02 09:53:03 UTC
It seems the MR is not energy-efficient and I am unable to add enough tests to prove it works (not possible to add a virtual disk in the test). Have to close it and mark the original bug as "CONFIRMED" again.
Comment 4 WS 2022-02-02 14:43:04 UTC
Such a shame.

Wait, how is it energy inefficient if Dolphin already needs to do half the task to show them in the device panel?
Comment 5 Fushan Wen 2022-02-02 15:02:44 UTC
(In reply to WS from comment #4)
> Such a shame.
> 
> Wait, how is it energy inefficient if Dolphin already needs to do half the
> task to show them in the device panel?

The side panel doesn't share the same code with KFileItem.
Comment 6 Fushan Wen 2022-02-02 16:10:41 UTC
To be more clear, to make a mount point show its icon, the sidebar only needs to simply list all mount points and give them icons. But in the folder view, each file item has to match the mount points and find the corresponding icon.
Comment 7 WS 2022-02-02 16:24:47 UTC
If you don't mind me asking, where is the energy inefficiency?
Comment 8 Fushan Wen 2022-02-02 16:28:25 UTC
If there are many folders in the view, matching mount points can be time-consuming.
Comment 9 WS 2022-02-02 16:48:17 UTC
But is that happening in every single folder in the main view, or only the ones that are the parent directory of mount points?