Bug 444753 - Detail view with a single column is missing right padding to fill the viewport
Summary: Detail view with a single column is missing right padding to fill the viewport
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: details mode (show other bugs)
Version: 21.08.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Tom Lin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-01 05:52 UTC by Tom Lin
Modified: 2022-01-16 14:01 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/system/dolphin/commit/d3839617193e92463806580699caa595c892b8a6
Version Fixed In: 22.04

Attachments
screenshot (75.11 KB, image/png)
2021-11-01 05:52 UTC, Tom Lin 		Details
normal (88.43 KB, image/png)
2021-11-01 05:54 UTC, Tom Lin 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Lin 2021-11-01 05:52:58 UTC 
Created attachment 143079 [details]
screenshot

SUMMARY

Detail view with only single column (i.e only the `Name` column) is missing right padding to fill the viewport.
This correct behaviour is restored once > 1 columns are enabled.
Also, when this bug is triggered, the alternating row colours disappear.

STEPS TO REPRODUCE
1. Right click on the header to disable all columns

OBSERVED RESULT

Column header doesn't pad to the right.
Alternating row colour missing.


EXPECTED RESULT

This should behave like having any other amount of columns enabled.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Tom Lin 2021-11-01 05:54:04 UTC 
Created attachment 143080 [details]
normal
Comment 2 Felix Ernst 2022-01-16 14:01:37 UTC 
Git commit d3839617193e92463806580699caa595c892b8a6 by Felix Ernst, on behalf of Tom Lin.
Committed on 16/01/2022 at 14:01.
Pushed by felixernst into branch 'master'.

Full row highlight implementation

This commit implements full-row selection and hover highlights for the
details view mode.

This commit also contains fixes for 444680, 444753, both uncovered
during this change.
Related: bug 181438, bug 444680
FIXED-IN: 22.04

M  +143  -36   src/kitemviews/kitemlistcontroller.cpp
M  +16   -0    src/kitemviews/kitemlistheader.cpp
M  +9    -0    src/kitemviews/kitemlistheader.h
M  +51   -5    src/kitemviews/kitemlistview.cpp
M  +11   -0    src/kitemviews/kitemlistview.h
M  +32   -0    src/kitemviews/kitemlistwidget.cpp
M  +10   -1    src/kitemviews/kitemlistwidget.h
M  +4    -0    src/kitemviews/kstandarditemlistview.cpp
M  +42   -10   src/kitemviews/kstandarditemlistwidget.cpp
M  +6    -0    src/kitemviews/kstandarditemlistwidget.h
M  +92   -34   src/kitemviews/private/kitemlistheaderwidget.cpp
M  +15   -0    src/kitemviews/private/kitemlistheaderwidget.h
M  +4    -0    src/settings/dolphin_detailsmodesettings.kcfg
M  +1    -0    src/views/dolphinitemlistview.cpp
M  +17   -0    src/views/dolphinview.cpp
M  +1    -0    src/views/dolphinview.h

https://invent.kde.org/system/dolphin/commit/d3839617193e92463806580699caa595c892b8a6