Bug 444554 - About page report bug button doesn't work if link doesn't have a query component
Summary: About page report bug button doesn't work if link doesn't have a query component
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.87.0
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
: 443303 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-10-28 18:21 UTC by george fb
Modified: 2021-12-16 02:12 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kirigami/commit/0580f068fe37a6936d82946d2d5f1d1b2de881e9
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description george fb 2021-10-28 18:21:35 UTC 
SUMMARY
If the bug address of KAboutData doesn't contain a query component (question mark ?) then the link is not opened.

https://invent.kde.org/frameworks/kirigami/-/blob/fd404d8351320de3d636d310d679039ab52fbfb4/src/controls/AboutPage.qml#L88

STEPS TO REPRODUCE
1. Use a qml application that uses Kirigami's AboutPage.qml
2. Change the bug address to "https://bugs.kde.org"
3. Open the about page
4. Click the "Report bug..." button

OBSERVED RESULT
Nothing happens

EXPECTED RESULT
https://bugs.kde.org is opened in the browser

ADDITIONAL INFORMATION
For Haruna with "https://bugs.kde.org" as bug address the link turn into "https://bugs.kde.org&component=generic&version=0.7.2"

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20211025
KDE Plasma Version: 5.23.1
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2
Kernel Version: 5.14.14-1-default (64-bit)
Graphics Platform: X11
Processors: 12 × AMD Ryzen 5 2600 Six-Core Processor
Memory: 15,5 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 750 Ti/PCIe/SSE2
Comment 1 Nate Graham 2021-10-28 21:12:25 UTC 
Please feel free to submit a fix!
Comment 2 Bug Janitor Service 2021-12-02 02:51:48 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/430
Comment 3 Bug Janitor Service 2021-12-02 12:10:31 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/431
Comment 4 Nate Graham 2021-12-13 22:40:02 UTC 
Git commit 0580f068fe37a6936d82946d2d5f1d1b2de881e9 by Nate Graham, on behalf of Aleix Pol.
Committed on 13/12/2021 at 22:37.
Pushed by ngraham into branch 'master'.

AboutPage: Only mess with the URL when we are dealing with KDE products

Otherwise open it as it was provided by the app author.

M  +7    -4    src/controls/AboutPage.qml

https://invent.kde.org/frameworks/kirigami/commit/0580f068fe37a6936d82946d2d5f1d1b2de881e9
Comment 5 Nate Graham 2021-12-16 02:12:28 UTC 
*** Bug 443303 has been marked as a duplicate of this bug. ***