Bug 444508 - Dolphin doesn't exit cleanly after opening terminal
Summary: Dolphin doesn't exit cleanly after opening terminal
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 21.08.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-27 20:35 UTC by Maciej Stanczew
Modified: 2021-11-18 22:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stanczew 2021-10-27 20:35:19 UTC
SUMMARY
After using Open Terminal feature, Dolphin process (and some kioslave5 processes) will not exit cleanly. Instead, they'll remain in process list indefinitely.

STEPS TO REPRODUCE
1. Open Dolphin
2. From the menu choose Open Terminal (Konsole in my case)
3. Close the newly opened terminal (optional, doesn't have effect on reproduction)
4. Close Dolphin
5. Check in process list (e.g. in ps or System Activity) that Dolphin exited

OBSERVED RESULT
Dolphin is still present in process list.

EXPECTED RESULT
Dolphin process should fully exit.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.23.2
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
The issue doesn't happen if step #2 is skipped: closing Dolphin after *not* using Open Terminal makes the process exit cleanly.
It also doesn't reproduce when opening the Terminal panel (the one at the bottom of Dolphin window).

I'm pretty sure this is a regression introduced in fix for bug #441072. Before this fix, Dolphin used kinit for opening the terminal, and it didn't hang after closing.
I first saw this issue with Arch package of Dolphin in version 21.08.0-2, which is base 21.08.0 with the patch from bug #441072 applied:
https://github.com/archlinux/svntogit-packages/commit/ed9afe2a441db57a5a85dc0fa4601ab9205ff6a9
https://invent.kde.org/system/dolphin/-/commit/27bfcde4efaf936243fc41e4a61d0cac32105ef6.patch
Comment 1 Nate Graham 2021-11-18 15:45:13 UTC
Cannot reproduce with those steps with current git master of everything. I don't think it could be a regression from the fix for Bug 441072 since that only made it into 21.12, and you're using 21.08.2. So you don't have the fix yet. I think it is highly likely that the reverse is true: that fix should fix this too. Any chance you can build Dolphin form source or use a dolphin-git AUR package or something to test that out?
Comment 2 Maciej Stanczew 2021-11-18 20:57:39 UTC
Arch package of Dolphin includes the fix for bug #441072 since 21.08.0-2, and that's the exact version when I started observing the issue:
https://github.com/archlinux/svntogit-packages/commit/ed9afe2a441db57a5a85dc0fa4601ab9205ff6a9

But good news: it doesn't reproduce anymore after upgrading to Frameworks 5.88.0. With Dolphin 21.08.3, Plasma 5.23.3, and Frameworks 5.87.0 I have the reproduction, and just upgrading Frameworks to 5.88.0 makes Dolphin exit cleanly. So, from my perspective this bug is fixed (should I mark it as Resolved myself?).
Comment 3 Nate Graham 2021-11-18 22:09:34 UTC
OK great!