Bug 444307 - OSD: Cycle through options by repeatedly pressing the triggering key
Summary: OSD: Cycle through options by repeatedly pressing the triggering key
Status: RESOLVED FIXED
Alias: None
Product: KScreen
Classification: Plasma
Component: OSD and Plasma applet (show other bugs)
Version: 5.23.1
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: kscreen-bugs-null@kde.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-24 04:47 UTC by kderemie
Modified: 2025-01-31 18:45 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kderemie 2021-10-24 04:47:49 UTC
SUMMARY

On Windows, Win+P opens the display mode cycler, but it also allows you to cycle through them with that same hotkey, rather than needing to move to the arrow keys or tab.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 21.10
KDE Plasma Version: 5.23.1
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2
Comment 1 Nate Graham 2022-11-08 22:36:12 UTC
You can use the arrow keys, FWIW.
Comment 2 nilskemail+kde 2024-10-11 16:17:09 UTC
Where does this code live? I have never worked on kwin/plasma but it could be a neat weekend project
Comment 3 Jakob Petsovits 2024-10-11 16:28:36 UTC
(In reply to nilskemail+kde from comment #2)
> Where does this code live? I have never worked on kwin/plasma but it could
> be a neat weekend project

In the /osd subdirectory of the kscreen repository: https://invent.kde.org/plasma/kscreen/-/tree/master/osd
Comment 4 Nate Graham 2024-10-11 20:20:55 UTC
We effectively have this in Plasma 6.2 now. I don't see us going back to the old large style but implementing the requested behavior with it.
Comment 5 Nate Graham 2024-10-11 20:40:09 UTC
Oops, my bad, I was confused! We do not have this in Plasma 6.2.
Comment 6 Nate Graham 2024-10-11 20:41:16 UTC
That said, I'm not sure cycling through the KScreen OSD really makes sense, unless there's also a separate explicit way to acknowledge the selection. Screen change operations can take a few seconds to complete, so you don't want to cause multiple such changes to trigger in the process of navigating to the desired one.

If you plan to work on this, do you have an idea for how we can avoid this?
Comment 7 Jakob Petsovits 2024-10-11 20:43:48 UTC
(In reply to Nate Graham from comment #6)
> That said, I'm not sure cycling through the KScreen OSD really makes sense,
> unless there's also a separate explicit way to acknowledge the selection.

The arrow-key navigation method already addresses this: nothing gets applied until you confirm by pressing Enter. Cycling with Meta+P should in effect have the same behavior as right-arrow (or in RTL layouts, left-arrow).
Comment 8 Nate Graham 2024-10-11 20:45:44 UTC
Yeah, that would probably work.
Comment 9 Nate Graham 2025-01-31 18:45:14 UTC
This has been implemented by Sergey Katunin with https://invent.kde.org/plasma/kscreen/-/merge_requests/343 for Plasma 6.4!