Bug 444271 - Track Mouse effect is activated only at mouse move
Summary: Track Mouse effect is activated only at mouse move
Status: CONFIRMED
Alias: None
Product: kwin
Classification: Unclassified
Component: effects-various (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor (vote)
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-23 14:15 UTC by Andrew Shark
Modified: 2021-10-25 21:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
vlad.zahorodnii: Wayland-
vlad.zahorodnii: X11+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Shark 2021-10-23 14:15:19 UTC
In the Track Mouse effect settings there are two ways to trigger it: keyboard shortcut or holding modifier keys. The problem is with the later.

When I press and hold down modifier keys (Meta+Ctrl), the effect is not activated. I though it was completely broken. I just discovered that it is working, but after you move your mouse.

Current behavior:
Do not move you mouse.
Hold Meta+Ctrl.
Observe that the effect is not activated.
Keep holding Meta+Ctrl and move your mouse a bit.
Observe the effect activated.
Do not move mouse and release Meta+Ctrl
Observe that effect is still activated.
Move your mouse a bit.
Observe the effect deactivated.

Expected behavior:
The effect should be activated while the Meta+Ctrl are pressed (without needing to move mouse), and deactivated as long as Meta+Ctrl are released (without needing to move mouse).

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.23.1
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Andrew Shark 2021-10-24 22:41:39 UTC
Looks like this is because of the subscribe function it listens is only when mouse is "changed". It is called TrackMouseEffect::slotMouseChanged():
https://invent.kde.org/plasma/kwin/-/blob/839293f98728b52525a779c260e99acf4717bb83/src/effects/trackmouse/trackmouse.cpp#L186

Probably, there should be something like TrackMouseEffect::modifierButtonsChanged().
Comment 2 Nate Graham 2021-10-25 21:46:36 UTC
Feel free to submit a patch!