Bug 444254 - "Decoration" items in Breeze-light (and Breeze-dark) "color" file redundant an faulty
Summary: "Decoration" items in Breeze-light (and Breeze-dark) "color" file redundant a...
Status: RESOLVED DUPLICATE of bug 444043
Alias: None
Product: Breeze
Classification: Plasma
Component: Color scheme (show other bugs)
Version: 5.23.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-23 06:55 UTC by PK
Modified: 2021-11-03 17:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Breeze-dark theme with the orriginal "colors" file in the theme (436.48 KB, image/jpeg)
2021-10-26 05:14 UTC, PK
Details
Breeze-dark blends in with system accent colors (443.29 KB, image/jpeg)
2021-10-26 05:24 UTC, PK
Details
explanation of the light-blue accents (253.54 KB, image/jpeg)
2021-10-26 05:26 UTC, PK
Details
orrignal breeze-dark colors-file (3.37 KB, text/plain)
2021-10-26 05:45 UTC, PK
Details
stripped down version of the "colors" file (3.42 KB, text/plain)
2021-11-02 14:09 UTC, PK
Details

Note You need to log in before you can comment on or make changes to this bug.
Description PK 2021-10-23 06:55:04 UTC
SUMMARY
The Decorations in the plasma-themes "Breeze-dark" and "Breeze-light" won't follow the chosen color-scheme 

STEPS TO REPRODUCE
1. choose a color-scheme
2. switch to the Plasma-themes Breeze-light or Breeze-dark
3. 

OBSERVED RESULT
The "Decoration" colors in the Plasma-theme are light blue

EXPECTED RESULT
The color of the Decoration follows the current color-scheme

I also found what is causing this behavior... When I open the "color" files with Kate and replace all instances of "Decoration" with "#Decoration" the plasma-themes will behave impeccable. Because of the cascading structure of the plasma system, plasma will fall back on "default" which is 100% perfect.
In this case less is more...

Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.1
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.3
Kernel Version: 5.11.0-37-generic (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Celeron® J4105 CPU @ 1.50GHz
Memory: 7.4 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 600

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-10-25 22:09:29 UTC
Can you please:

1.attach a screenshot that shows the problem
2. Attach the faulty color scheme in questioin
3. Mention the exact paths of the color scheme and the fallback you're referring to
Comment 2 PK 2021-10-26 05:14:13 UTC
Created attachment 142890 [details]
Breeze-dark theme with the orriginal "colors" file in the theme

The systemsettings color-module is also to be seen. I am using a color-scheme with orange accent-color as you can see
Comment 3 PK 2021-10-26 05:24:13 UTC
Created attachment 142891 [details]
Breeze-dark blends in with system accent colors

To achieve this situation I copied the folder /usr/share/plasma/desktoptheme/breeze-dark to the ~/local/share/plasma/desktoptheme folder, then I opened the colors-file with Kate and "search-and-replaced" all instances of "Decoration" with "#Decoration" automatically.
There are 16 items replaced. The result looks good.
Comment 4 PK 2021-10-26 05:26:42 UTC
Created attachment 142892 [details]
explanation of the light-blue accents

Kcolorchooser shows the color that the "Decorations" are originally set to.
Comment 5 PK 2021-10-26 05:31:25 UTC
You can just leave away information in a plasma-theme. KDE fills in the holes by using the theme "default". This theme is also found in the folder /usr/share/plasma/desktoptheme. In my opinion the theme "default" is a masterpiece that functions as a safety net...
Comment 6 PK 2021-10-26 05:45:42 UTC
Created attachment 142893 [details]
orrignal breeze-dark colors-file

This file is located in the folder /usr/share/plasma/desktoptheme/breeze-dark. The user can overwrite it by putting it in his own folder ~/.local/share/plasma/desktoptheme/breeze-dark and changing it.
Comment 7 Nate Graham 2021-10-29 05:04:20 UTC
Thanks. I am still a little bit unsure what the problem is, exactly. What default color scheme is it falling back to?
Comment 8 PK 2021-10-29 05:50:43 UTC
I would expect that the Plasma-themes "Breeze-light" and "Breeze-dark" would just be as beautiful and refined as the "Breeze" Plasma theme only without the panel following the system-colors automatically (dark/light).
This turns out to be not the case. Not only do the panels stay dark or light (good) but the decoration color in the panel is fixed too! I my opinion that is an unnecessary deterioration.
Of course I am not 100% sure of what I say about the fall-back. But after some searching I found out that commenting out the "Decoration" items in the "colors" files of the Plasma-themes Breeze-light and Breeze-dark had a good effect.


(as far as the "default" thing concerns: I created a folder "experiment" in my folder ~/.local/share/plasma/desktoptheme and copied and paste in the file metadata-desktop from another plasma-theme. I added nothing else to the newly made plasma-theme folder. 
In this theme "experiment" I changed the line "X-KDE-PluginInfo-Name=orriginal-name" in the file "metadata-desktop" to "X-KDE-PluginInfo-Name=experiment". 
The theme "experiment" shows up in the systemsettings. And, as I expected, it is an exact copy of het Breeze Plasma-theme. This is, I think, because the default Plasma-theme fills in the holes)
Comment 9 PK 2021-10-29 14:34:10 UTC
Now I am looking at your comment 7 and I feel I perhaps could be clearer.
Plasma-themes bring with them their own icons, panels, etc etc. They also bring with them a file (located in the folder of the plasma-theme) "colors". In this file lays down what colors the plasma-theme uses.
If one of all components (or parts there off) is missing, this missing part is filled in from the "default" plasma theme (/usr/share/plasma/desktoptheme/default). 
This "default" plasma-theme manifests itself to us under the name of "Breeze".
And the Breeze plasma-theme (or the default theme if you want) has as specialty that is adapts to the current system-colors.
So when the Breeze-light plasma theme doesen't specify decoration-colors in its "color" file the "default" plasma theme takes care of this missing colors. 
And the "default" plasma theme follows system-colors.
Comment 10 Nate Graham 2021-10-29 15:21:33 UTC
Ah I get it now.

*** This bug has been marked as a duplicate of bug 444043 ***
Comment 11 PK 2021-11-02 14:09:50 UTC
Created attachment 143138 [details]
stripped down version of the "colors" file

I "commented out" some more of the values in the "colors" file of the Breeze-dark plasma-theme and imho it made the theme only better...
Comment 12 Nate Graham 2021-11-03 17:14:56 UTC
Please feel free to submit a merge request to change that! People are eager to see Bug 444043 fixed.