Bug 444145 - Buttons on the "Send to device" dialog need some polishing
Summary: Buttons on the "Send to device" dialog need some polishing
Status: RESOLVED FIXED
Alias: None
Product: frameworks-purpose
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.87.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-10-20 20:20 UTC by Nagy Tibor
Modified: 2021-10-21 14:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.88
Sentry Crash Report:


Attachments
Screenshot (16.37 KB, image/png)
2021-10-20 20:20 UTC, Nagy Tibor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nagy Tibor 2021-10-20 20:20:41 UTC
Created attachment 142692 [details]
Screenshot

SUMMARY
The "Send to device" dialog of KDE Connect has several usability issues. This ticket is only about issues regarding the two buttons at the bottom of the dialog.

1. Wrong button alignment
KDE dialogs align their primary buttons to the right side, not the left side. Couldn't find HIG guidelines on this, but you can check any other KDE dialogs for reference.

2. Weird button labels
The [Run] and [Back] button labels feel extremely weird on a file sharing dialog. You're not trying to run something, you're trying to send something. Shouldn't they say [Send] and [Cancel]? That would more accurately describe their purpose.

3. Buttons have no icons
They help quickly recognizing which button does what.

4. No default button specified
Helps quickly recognizing which button does what.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.1
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.3
Comment 1 Nate Graham 2021-10-21 13:35:24 UTC
Working on it.
Comment 2 Bug Janitor Service 2021-10-21 13:59:57 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/purpose/-/merge_requests/43
Comment 3 Nate Graham 2021-10-21 14:00:31 UTC
Unfortunately setting a default button can't easily be done in this type of dialog, but I can fix everything else.
Comment 4 Nate Graham 2021-10-21 14:08:15 UTC
Git commit 216ecc5214991ae52b78850ecb177d536286c8d4 by Nate Graham.
Committed on 21/10/2021 at 14:05.
Pushed by ngraham into branch 'master'.

Improve job window buttons

1. Use more relevant text
2. Give them icons
3. Correctly disable the Send button when no device is selected
FIXED-IN: 5.88

M  +3    -0    src/plugins/bluetooth/bluetoothplugin_config.qml
M  +3    -0    src/plugins/kdeconnect/kdeconnectplugin_config.qml
M  +12   -3    src/quick/JobView.qml

https://invent.kde.org/frameworks/purpose/commit/216ecc5214991ae52b78850ecb177d536286c8d4