Bug 444070 - Advanced color selector history swatches height/width backwards when in horizontal mode.
Summary: Advanced color selector history swatches height/width backwards when in horiz...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color Selectors (other bugs)
Version First Reported In: 4.4.8
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Tiar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-20 01:25 UTC by Al Hunt
Modified: 2023-04-20 19:54 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Krita System Information text paste (3.01 KB, text/plain)
2021-10-20 01:25 UTC, Al Hunt
Details
Krita help/about log dump text (126.92 KB, text/plain)
2021-10-20 01:31 UTC, Al Hunt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Al Hunt 2021-10-20 01:25:42 UTC
Created attachment 142647 [details]
Krita System Information text paste

SUMMARY

STEPS TO REPRODUCE
1. Configure Krita
2. Color Selector Settings
3. Color History tab
4. Layout: HORIZONTAL (Rows: 1)
5. Patch Options: Height 32 px, Width 16 px, Max Patches 20, allow scrolling yes

OBSERVED RESULT
The shape of the color history swatches is dimensionally reversed. In Horizontal layout mode, Height value adjusts the visual width, and width adjusts the visual height or the resulting color swatches.

EXPECTED RESULT
In Horizontal mode, the Width setting would adjust how wide the swatch is, and Height would adjust how tall.

SOFTWARE/OS VERSIONS
Edition	Windows 10 Pro
Version	20H2
Installed on	‎11/‎4/‎2020
OS build	19042.1288
Experience	Windows Feature Experience Pack 120.2212.3920.0

ADDITIONAL INFORMATION
Very new user.
Comment 1 Al Hunt 2021-10-20 01:31:22 UTC
Created attachment 142648 [details]
Krita help/about log dump text
Comment 2 Al Hunt 2021-10-20 07:17:24 UTC
Comment on attachment 142648 [details]
Krita help/about log dump text

No relation to this bug. Please ignore/delete.
Comment 3 Tiar 2023-04-20 19:54:50 UTC
Git commit 1e6b3e9b768d27d276be4447b67070f9effe5802 by Agata Cacko.
Committed on 20/04/2023 at 19:54.
Pushed by tymond into branch 'master'.

Fix height and width mixed up in color history

Before this commit, adjusting Height would adjust the width
of the color swatch, and adjusting the Width would adjust the height
of it.
Since it only changes the text on screen (other than that, the code
is consistent), it won't change the look of color selector
for anyone who already adjusted it to their liking.

M  +2    -2    plugins/dockers/advancedcolorselector/wdg_color_selector_settings.ui

https://invent.kde.org/graphics/krita/commit/1e6b3e9b768d27d276be4447b67070f9effe5802