Created attachment 142332 [details] project file If a clip is deleted from the project timecode links are broken for all clips which had been added after the clip deleted. STEPS TO REPRODUCE 1. Create a new project 2. Add 3 video clips 3. Add one note with "insert current timecode" for each clip; aterwards there should be 3 notes in the list 4. Delete clip 2 (the one added as second) 5. Save the project 6. Restart kdenlive OBSERVED RESULT The timestamps links in the project notes behave as follows: note 1: links to clip 1 (correct) note 2: links to clip 3 (wrong) note 3: links to nothing (wrong) EXPECTED RESULT The timestamps links in the project notes behave as follows: note 1: links to clip 1 note 2: links to nothing (since clip has been deleted) note 3: links to clip 3 SOFTWARE/OS VERSIONS KDE Frameworks Version: 5.86.0 Qt Version: 5.15.3
I really like the project notes feature - I used to do them on paper before. However it is really annoying that deling one clip renders all the timestamp links useless.
I'm currently using Kubuntu 24.04 with KDE Plasma 5.27.11 and Qt 5.15.13. The steps described to reproduce the bug are still the same.
Right, the Project Notes use the Clip's Bin Id that is not guaranteed to remain the same between sessions. I have to switch it to use the recently introduced control UUID. Working on it.
Great that you are fixing this :-) Let me know when you have an AppImage to test the fix.
Git commit bfd94813825bffd241af0ef81d19ae68036e1a2b by Jean-Baptiste Mardelle. Committed on 22/08/2024 at 04:41. Pushed by mardelle into branch 'master'. Fix document notes timecode links may be broken after project reload M +5 -0 src/bin/projectclip.cpp M +2 -0 src/bin/projectclip.h M +43 -2 src/bin/projectitemmodel.cpp M +4 -1 src/bin/projectitemmodel.h M +9 -2 src/project/dialogs/noteswidget.cpp M +12 -6 src/project/notesplugin.cpp M +12 -3 src/project/projectmanager.cpp M +1 -1 src/project/projectmanager.h https://invent.kde.org/multimedia/kdenlive/-/commit/bfd94813825bffd241af0ef81d19ae68036e1a2b
Should now be fixed in the devel AppImage: https://cdn.kde.org/ci-builds/multimedia/kdenlive/master/linux/
Looks like you fixed the bug :-) At least I cannot reproduced it anymore using the "steps to reproduce". Thanks a lot for your work!!
Git commit 2fd7cad71dd060739086a88f216fa8edc3c0714e by Jean-Baptiste Mardelle. Committed on 23/08/2024 at 09:11. Pushed by mardelle into branch 'release/24.08'. Fix document notes timecode links may be broken after project reload M +5 -0 src/bin/projectclip.cpp M +2 -0 src/bin/projectclip.h M +43 -2 src/bin/projectitemmodel.cpp M +4 -1 src/bin/projectitemmodel.h M +9 -2 src/project/dialogs/noteswidget.cpp M +12 -6 src/project/notesplugin.cpp M +12 -3 src/project/projectmanager.cpp M +1 -1 src/project/projectmanager.h https://invent.kde.org/multimedia/kdenlive/-/commit/2fd7cad71dd060739086a88f216fa8edc3c0714e