Bug 443535 - No logo icon in the about window
Summary: No logo icon in the about window
Status: RESOLVED FIXED
Alias: None
Product: Haruna
Classification: Applications
Component: generic (show other bugs)
Version: 0.7.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: george fb
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-10 06:11 UTC by Luigi Baldoni
Modified: 2021-10-31 18:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
haruna about window (55.53 KB, image/jpeg)
2021-10-10 06:11 UTC, Luigi Baldoni 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Luigi Baldoni 2021-10-10 06:11:23 UTC 
Created attachment 142290 [details]
haruna about window

SUMMARY
Apparently missing icon in the about window

STEPS TO REPRODUCE
1. Click on Help/About Haruna
2.
3. 

OBSERVED RESULT
Blank logo at the top left

EXPECTED RESULT
Some sort of icon at that location

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Leap 15.3
KDE Plasma Version: 5.18.6
KDE Frameworks Version: 5.76.0
Qt Version: 5.12.7

ADDITIONAL INFORMATION
Comment 1 Gabriel 2021-10-15 15:35:36 UTC 
Can't replicate the issue. Do you still experience it?

Haruna Version: 0.7.2
KDE Plasma Version: 5.23.0
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.3
Comment 2 Luigi Baldoni 2021-10-15 16:28:49 UTC 
> Can't replicate the issue. Do you still experience it?

I do (on 0.7.2).
The problem is that the program looks for haruna.svg, but the icon file is now named org.kde.haruna.svg.

Renaming it solves the problem, not sure where to look in the tree.
Comment 3 Gabriel 2021-10-15 16:55:46 UTC 
(In reply to Luigi Baldoni from comment #2)
Aha interesting. So maybe it's been changed, and those who installed it before the change would get the issue after updating, while new installs don't? If so it would make sense why I didn't experience any issue. :^)
Comment 4 Luigi Baldoni 2021-10-15 17:57:04 UTC 
(In reply to Gabriel from comment #3)
> (In reply to Luigi Baldoni from comment #2)
> Aha interesting. So maybe it's been changed, and those who installed it
> before the change would get the issue after updating, while new installs
> don't? If so it would make sense why I didn't experience any issue. :^)

I don't know the version you're using and how it was installed.
Is it a distro package or did you build it yourself?
Comment 5 Gabriel 2021-10-15 18:18:18 UTC 
(In reply to Luigi Baldoni from comment #4)
> I don't know the version you're using and how it was installed.
> Is it a distro package or did you build it yourself?
Oh, as noted in my first comment it's version 0.7.2. The install on my main system (Neon user ed.*) is a Flatpak, but I also tend to verify bugs on Neon testing, on which it's installed through the neon-focal-main repo. In both cases the icon shows up as it should. :^|

*Plasma Version: 5.23.0
 Frameworks Version: 5.87.0
 Qt Version: 5.15.3
Comment 7 Luigi Baldoni 2021-10-17 07:53:02 UTC 
(In reply to george fb from comment #6)
> Should be fixed
> https://invent.kde.org/multimedia/haruna/-/commit/
> 55878fd6775a6f7d8a6dfdcbc44673a6b40ebf10

I don't understand. Why install it twice? Couldn't it be renamed in the code?
Comment 8 george fb 2021-10-21 10:27:05 UTC 
(In reply to Luigi Baldoni from comment #7)
> I don't understand. Why install it twice? Couldn't it be renamed in the code?

It can, did it this way because that's what flatpak sugests and I forgot I can rename it for flatpak too.
Comment 9 Luigi Baldoni 2021-10-31 12:13:09 UTC 
The problem is still present as of 0.7.2+git20211031.8190c04. Now it's looking for generic.svg instead of haruna.svg.
Comment 10 george fb 2021-10-31 17:22:16 UTC 
Should be fixed now.
Comment 11 Luigi Baldoni 2021-10-31 18:03:32 UTC 
(In reply to george fb from comment #10)
> Should be fixed now.

I confirm.