Bug 443399 - clazy-inefficient-qlist makes no sense anymore with Qt 6
Summary: clazy-inefficient-qlist makes no sense anymore with Qt 6
Status: RESOLVED FIXED
Alias: None
Product: clazy
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Sergio Martins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-06 14:06 UTC by christian.kandeler
Modified: 2021-10-13 22:24 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description christian.kandeler 2021-10-06 14:06:47 UTC
Not sure what the best solution is, but right now, using clazy with Qt 6 projects will trigger nonsensical warnings about QList by default.
Comment 1 Sergio Martins 2021-10-10 23:08:46 UTC
yeah, I'll disable it for Qt6
Comment 2 Sergio Martins 2021-10-13 22:24:26 UTC
Git commit d86b9dc6b5ae57e204f6715d2f6113cc196d2d98 by Sergio Martins.
Committed on 13/10/2021 at 22:22.
Pushed by smartins into branch 'master'.

Remove inefficient-qlist check, the issue has been fixed in Qt6

Newer project can use Qt6.
Old Qt5 projects shouldn't be doing such invasive changes.

If this check was about uncovering bugs instead of reducing
performance pessimisation then we could keep it for Qt5 code in
production, that's not the case however.

M  +1    -0    Changelog
M  +0    -2    CheckSources.cmake
M  +0    -1    ClazySources.cmake
M  +0    -2    ClazyTests.cmake
M  +0    -2    README.md
M  +0    -12   checks.json
D  +0    -7    docs/checks/README-inefficient-qlist-soft.md
D  +0    -5    docs/checks/README-inefficient-qlist.md
M  +0    -2    readmes.cmake
M  +0    -4    src/Checks.h
D  +0    -117  src/checks/inefficientqlistbase.cpp
D  +0    -63   src/checks/inefficientqlistbase.h
D  +0    -34   src/checks/level1/inefficient-qlist-soft.cpp
D  +0    -47   src/checks/level1/inefficient-qlist-soft.h
D  +0    -35   src/checks/manuallevel/inefficient-qlist.cpp
D  +0    -46   src/checks/manuallevel/inefficient-qlist.h
D  +0    -7    tests/inefficient-qlist-soft/config.json
D  +0    -91   tests/inefficient-qlist-soft/main.cpp
D  +0    -3    tests/inefficient-qlist-soft/main.cpp.expected
D  +0    -8    tests/inefficient-qlist/config.json
D  +0    -55   tests/inefficient-qlist/main.cpp
D  +0    -4    tests/inefficient-qlist/main.cpp.expected
D  +0    -4    tests/inefficient-qlist/main.cpp.expected.x86

https://invent.kde.org/sdk/clazy/commit/d86b9dc6b5ae57e204f6715d2f6113cc196d2d98