Bug 443382 - [KCommandBar] Don't display empty space on the left if no item has an icon
Summary: [KCommandBar] Don't display empty space on the left if no item has an icon
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kwidgetsaddons
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 5.86.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Christoph Feck
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-06 08:14 UTC by popov895
Modified: 2021-10-16 15:23 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kconfigwidgets/commit/4ff9e5dd7ecd4821967b3f509046c2418f67149a
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Empty space on the left (29.07 KB, image/jpeg)
2021-10-06 08:14 UTC, popov895 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2021-10-06 08:14:59 UTC 
Created attachment 142201 [details]
Empty space on the left

SUMMARY

At the moment, there is empty space on the left, even if no item has an icon. This empty space can be used for a command name, and it also looks weird. As an example, you can look at the menu, that has no empty space on the left if no menu item has an icon. IMO, this is reasonable behavior.

SOFTWARE/OS VERSIONS

Operating System: openSUSE Tumbleweed 20210929
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Bug Janitor Service 2021-10-10 11:10:11 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/79
Comment 2 Waqar Ahmed 2021-10-16 15:23:37 UTC 
Git commit 4ff9e5dd7ecd4821967b3f509046c2418f67149a by Waqar Ahmed, on behalf of Eugene Popov.
Committed on 16/10/2021 at 10:42.
Pushed by waqar into branch 'master'.

[KCommandBar] Don't display an indent for an icon if no item has an icon

This MR makes the CommandBarStyleDelegate not to display an indent for an icon if no item has an icon.

M  +44   -30   src/kcommandbar.cpp

https://invent.kde.org/frameworks/kconfigwidgets/commit/4ff9e5dd7ecd4821967b3f509046c2418f67149a