Bug 443294 - Using "Screen Edge" to change its position from vertical to horizontal will cause incorrect position of controls
Summary: Using "Screen Edge" to change its position from vertical to horizontal will c...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Unclassified
Component: Panel (show other bugs)
Version: master
Platform: openSUSE RPMs Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-04 12:17 UTC by Fushan Wen
Modified: 2021-11-23 03:44 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.24


Attachments
Controls (97.06 KB, image/png)
2021-10-04 12:17 UTC, Fushan Wen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2021-10-04 12:17:22 UTC
Created attachment 142132 [details]
Controls

SUMMARY
When I drag a panel using "Screen Edge" and change its position from vertical to horizontal, the position of controls in the configuration bar is incorrect.

STEPS TO REPRODUCE
1. Right click on a vertical panel - Enter Edit Mode
2. Use "Screen Edge" to change its position to horizontal.

OBSERVED RESULT
See the attachment

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20210929
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2
Kernel Version: 5.14.6-1-default (64-bit)
Graphics Platform: X11
Processors: 8 × AMD Ryzen 7 4700U with Radeon Graphics
Memory: 15.0 GiB of RAM
Graphics Processor: AMD RENOIR
Comment 1 Bug Janitor Service 2021-10-04 15:22:14 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/586
Comment 2 Nate Graham 2021-11-23 03:41:11 UTC
Git commit 628e04f5b5dd0e65b6a7669ad46db23709874f86 by Nate Graham, on behalf of Fushan Wen.
Committed on 23/11/2021 at 03:39.
Pushed by ngraham into branch 'master'.

Panel: Set ToolBar state in PanelConfiguration.qml

This prevents misalignment of controls in the toolbar.

M  +1    -0    desktoppackage/contents/configuration/PanelConfiguration.qml
M  +0    -1    desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

https://invent.kde.org/plasma/plasma-desktop/commit/628e04f5b5dd0e65b6a7669ad46db23709874f86
Comment 3 Nate Graham 2021-11-23 03:41:19 UTC
Git commit c9750c14dbc118266b09c66923e868ae1e421a64 by Nate Graham, on behalf of Fushan Wen.
Committed on 23/11/2021 at 03:39.
Pushed by ngraham into branch 'master'.

Use implicitWidth/implicitHeight of controls to calculate implicitWidth/implicitHeight of root

Do not use Layout's implicitWidth/implicitHeight as they are updated too late

M  +15   -2    desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

https://invent.kde.org/plasma/plasma-desktop/commit/c9750c14dbc118266b09c66923e868ae1e421a64