Bug 443241 - Tab bar has positioning code specific to Breeze Plasma theme SVGs which may not work with 3rd-party themes
Summary: Tab bar has positioning code specific to Breeze Plasma theme SVGs which may n...
Status: CONFIRMED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: 5.22.90
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-10-03 02:29 UTC by doncbugs
Modified: 2022-08-03 23:34 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
the highlight for Applications is cut off (11.40 KB, image/png)
2021-10-03 02:29 UTC, doncbugs
Details
tabbar.svg now overlaps with the separating line for the panel (8.28 KB, image/png)
2022-08-03 23:34 UTC, doncbugs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description doncbugs 2021-10-03 02:29:55 UTC
Created attachment 142105 [details]
the highlight for Applications is cut off

SUMMARY
Kickoff appears to be one pixel lower than it needs to be. Tabbar that make use of it appear strange.

STEPS TO REPRODUCE
1. Apply a theme whose tabbar svg has a thin line at the bottom for best visibility
2. Open Kickoff
3. 

OBSERVED RESULT
The tabbar element for Applications and Places is cut off by 1 pixel at the bottom

EXPECTED RESULT
The entire tabbar element should be visible

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 David Edmundson 2021-10-03 20:17:26 UTC Comment hidden (spam)
Comment 2 doncbugs 2021-10-04 03:25:03 UTC
(In reply to David Edmundson from comment #1)

I like to think of representing a variety of themes properly as yet another amazing feature of plasma.

I'm wondering if it has anything to do with the separator line between the panel and attached plasmoids.
Comment 3 Nate Graham 2021-10-04 23:53:49 UTC
IIRC that code weirdness was done specifically to allow the Breeze tab highlight effect to touch the border. It's probably messing up 3rd-party themes because their metrics are different.
Comment 4 doncbugs 2021-10-05 08:21:42 UTC
(In reply to Nate Graham from comment #3)
> IIRC that code weirdness was done specifically to allow the Breeze tab
> highlight effect to touch the border.

Well that's kind of irritating. I really wish we'd take better care of supporting our themes. The thought of becoming an 'adwaita'-only type of suite is rather unsettling. KDE has access to the coolest theme systems, probably out of all of the desktops on Linux, that anyone with Inkscape can make their own. With Aurorae barely on life support and Kvantum moving ever further away as things get rewritten, I really hope Plasma doesn't bite the dust too.
Comment 5 Nate Graham 2021-10-05 13:16:08 UTC
It was an oversight, not a long-term change in direction. :) We can fix it. Note that these bug reports are valuable, because most core Plasma developers don't use 3rd-party themes on a regular basis. We know it's something our users care very much about, but most of us are focused on improving our own default theme, which naturally introduces bugs like these when we forget about third-party themes. Oops. Sorry about that.

FWIWin the long term, we want to try to unify theming possibilities for Plasma and KDE apps somehow, so that it's easy to apply the same theme to both and using Kvantum becomes unnecessary.
Comment 6 doncbugs 2021-10-06 06:00:16 UTC
(In reply to Nate Graham from comment #5)
> FWIWin the long term, we want to try to unify theming possibilities for
> Plasma and KDE apps somehow, so that it's easy to apply the same theme to
> both and using Kvantum becomes unnecessary.

I don't know if I want the plasma style and application style to be the same thing, but if an even more flexible version of Kvantum can exist without every application looking broken, I'm on board. I suspect sooner rather than later will cut down on these oversights since Kvantum's main downside is that hard-coded styles immediately become visible when the theme is changed from minimal, wireframe styles. Fixing that would be quite a task.

I'd be more than happy to join the discussion and give my 2 cents if you can point me in the right direction.
Comment 7 Nate Graham 2021-10-06 16:40:15 UTC
Sure, take a look here: https://phabricator.kde.org/T13467
Comment 8 doncbugs 2022-08-03 23:34:57 UTC
Created attachment 151100 [details]
tabbar.svg now overlaps with the separating line for the panel

I was wondering why this wasn't marked as resolved so I tried the theme out again. Humorously, now it's overlapping with the line that's used to separate the panel.