Bug 443014 - [Gmic] Bug in the preview of filters
Summary: [Gmic] Bug in the preview of filters
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: G'Mic for Krita (show other bugs)
Version: 5.0.0-beta1
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-27 13:58 UTC by David REVOY
Modified: 2021-10-13 15:44 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2021-09-27 13:58:42 UTC
SUMMARY
Hi, at first launch, many filters don't show any previews.

STEPS TO REPRODUCE
1. Create a 1000x1000 new document, draw a random colored stroke of painting
2. Open GMIC (Filter > Start GMIC Qt)
3. Go to 'Colors' > 'Boost Chromacity' 

OBSERVED RESULT
The preview viewport of GMIC is empty (transparency checkerboard). Resizing the windows will display the result. Moving the preview will make this one go back to transparent checkerboard.

Switching to another filter (eg. 'Basic Adjustement' just above it) and coming back sort of fix the preview.


EXPECTED RESULT
Get the preview of GMIC working at the first launch


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 20.04LTS
Appimage: krita-5.0.0-beta1-x86_64.appimage
Comment 1 David REVOY 2021-09-27 14:30:32 UTC
@amyspark: Here is the test you adviced on IRC:

I can reproduce the bug on krita-5.0.0-beta1-0c28050-x86_64.appimage (fresh 5.0 beta plus, Gmic 2.9.9) but it is less frequent (I need to load the filter and switch between a couple of filter to trigger the empty preview).

Something weird: I can't make krita-5.1.0-prealpha-3e23fc2-x86_64.appimage to bug the same way. It is robust on it.
Comment 2 amyspark 2021-09-27 17:49:17 UTC
Hi David!

I've been able to confirm it works as "expected". I implemented all of GMic's available layer modes, and the filter stdlib says the default for "Boost Chromaticity" is "NoInput". In layperson's terms, the default value for this filter's Input layers is "None".

Can you confirm that pressing the little refresh button beside the Input Layers selector does fix this issue?
Comment 3 amyspark 2021-09-27 17:50:34 UTC
> I implemented all of GMic's available layer modes

I didn't say that this mode isn't available in 4.4.8, only in the v5 plugin, this is why the issue hadn't arisen before.
Comment 4 David REVOY 2021-09-27 18:12:41 UTC
I confirm: the layer has "None" and refreshing the Input/Output (or setting manually the Input Layer to "Active (default)" fixes it.
Comment 5 amyspark 2021-09-27 18:52:51 UTC
Fixed in https://github.com/amyspark/gmic/commit/5ef15eb73418f367217b7d520dedffa716db8dbc. It'll be rolled up in the next beta.
Comment 6 Bug Janitor Service 2021-10-04 14:25:41 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1077
Comment 7 amyspark 2021-10-04 14:38:59 UTC
Git commit 25a238912175837a29586fab58a414b46c8614de by L. E. Segovia.
Committed on 04/10/2021 at 14:19.
Pushed by dkazakov into branch 'krita/5.0'.

GMIC: update to 2.9.9 patch 2

M  +2    -2    3rdparty/ext_gmic/CMakeLists.txt
M  +2    -2    3rdparty_plugins/ext_gmic/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/25a238912175837a29586fab58a414b46c8614de
Comment 8 Dmitry Kazakov 2021-10-04 14:39:37 UTC
Git commit 3901afa9f1b388b15a0b61f100e9d87a0ffe9e87 by Dmitry Kazakov, on behalf of L. E. Segovia.
Committed on 04/10/2021 at 14:39.
Pushed by dkazakov into branch 'master'.

GMIC: update to 2.9.9 patch 2

M  +2    -2    3rdparty/ext_gmic/CMakeLists.txt
M  +2    -2    3rdparty_plugins/ext_gmic/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/3901afa9f1b388b15a0b61f100e9d87a0ffe9e87
Comment 9 David REVOY 2021-10-13 15:44:08 UTC
I confirm the fix: I can't reproduce on krita-5.0.0-beta2-x86_64.appimage with 2.9.9 Gmic. Thank you @amyspark ! :-)