Bug 442852 - Fast user switching is broken since 5.23 beta
Summary: Fast user switching is broken since 5.23 beta
Status: RESOLVED FIXED
Alias: None
Product: ksmserver
Classification: Plasma
Component: general (show other bugs)
Version: 5.22.90
Platform: Other Linux
: VHI grave
Target Milestone: ---
Assignee: David Edmundson
URL:
Keywords: regression
: 443085 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-09-23 17:25 UTC by hexchain
Modified: 2021-09-28 20:34 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description hexchain 2021-09-23 17:25:20 UTC
SUMMARY
Fast user switching is broken in 5.22.90. It worked back in 5.22.

STEPS TO REPRODUCE
1. Lock screen
2. Click "Switch user"
3. Create or choose a session

OBSERVED RESULT
The blur overlay disappears, leaving only the wallpaper on screen, and nothing else happens.

EXPECTED RESULT
Either the display manager is brought up or the active session should switch to the chosen one.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.22.90
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2
Kernel Version: 5.14.5-zen1-1-zen (64-bit)
Graphics Platform: X11
Processors: 16 × AMD Ryzen 7 4800H with Radeon Graphics
Memory: 29.8 GiB of RAM
Graphics Processor: AMD RENOIR

ADDITIONAL INFORMATION
There is only one seemingly relevant log:

> kscreenlocker_greet[399318]: file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml:436: TypeError: Cannot read property 'vtNumber' of undefined

I'm willing to provide more information.
Comment 1 Nate Graham 2021-09-24 19:28:52 UTC
Can confirm, eek.

Might actually be the root cause of Bug 439873.
Comment 2 Ash Blake 2021-09-26 20:44:53 UTC
This is a regression from commit 714ce4045e0cbbba1d440b2fcb6f547f2680799f in plasma-workspace.

The property m which exposed the model has been removed from UserDelegate, but it wasn't unused. In SessionManagementScreen, userListCurrentModelData was supposed to be pointing at userListView.currentItem.m which is now undefined.

The only usage of userListCurrentModelData is in LockScreenUi.qml:436, where the TypeError occurs. 

Reverting that commit makes user switching work again.
Comment 3 David Edmundson 2021-09-26 20:57:56 UTC
Adding author as CC.
Comment 4 Ash Blake 2021-09-26 21:58:20 UTC
Proposed fix that also fixes the original warnings: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1081
Comment 5 Bug Janitor Service 2021-09-26 22:43:18 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1082
Comment 6 Aleix Pol 2021-09-27 18:42:30 UTC
Git commit a668c7018dc61b0e0b77e19657d735ec743b5676 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 27/09/2021 at 18:41.
Pushed by apol into branch 'master'.

Address regression in VT switching code
Related: bug 439873

M  +1    -1    lookandfeel/contents/components/SessionManagementScreen.qml
M  +1    -0    lookandfeel/contents/components/UserDelegate.qml
M  +1    -0    lookandfeel/contents/components/UserList.qml
M  +6    -1    lookandfeel/contents/lockscreen/LockScreenUi.qml

https://invent.kde.org/plasma/plasma-workspace/commit/a668c7018dc61b0e0b77e19657d735ec743b5676
Comment 7 Aleix Pol 2021-09-27 18:43:11 UTC
Git commit 3201576c3fc456f066ff4ead2acd2d64c14e2e9c by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 27/09/2021 at 18:42.
Pushed by apol into branch 'Plasma/5.23'.

Address regression in VT switching code
Related: bug 439873


(cherry picked from commit a668c7018dc61b0e0b77e19657d735ec743b5676)

M  +1    -1    lookandfeel/contents/components/SessionManagementScreen.qml
M  +1    -0    lookandfeel/contents/components/UserDelegate.qml
M  +1    -0    lookandfeel/contents/components/UserList.qml
M  +6    -1    lookandfeel/contents/lockscreen/LockScreenUi.qml

https://invent.kde.org/plasma/plasma-workspace/commit/3201576c3fc456f066ff4ead2acd2d64c14e2e9c
Comment 8 Nate Graham 2021-09-28 20:34:00 UTC
*** Bug 443085 has been marked as a duplicate of this bug. ***