Bug 442600 - Animation speed setting is ignored after reverting compositor settings to default values
Summary: Animation speed setting is ignored after reverting compositor settings to def...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (other bugs)
Version First Reported In: 5.22.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-17 14:02 UTC by Patrick Silva
Modified: 2021-09-22 15:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.23
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-09-17 14:02:41 UTC
STEPS TO REPRODUCE
1. set Scale Method and Lattency to non-default values in Compositor KCM
2. set animation speed to instant in General Behavior KCM and test it by minimizing/unminimizing windows with click on task manager: animation is instant as expected
3. go to Compositor KCM, click on "Defaults" and then "Apply" buttons
4. minimize/unminimize windows by clicking on task manager: animation is no longer instant
5. go to General Behavior KCM: animation speed slider is still adjusted to instant animation
6. use the slider to set another animation speed, apply the change and test it: the change done has no effect. I need to delete kwinrc to make animation speed setting to work again.

EXPECTED RESULT
animation speed setting should always take effect 

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.22.90
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2
Graphics Platform: Wayland
Comment 1 Vlad Zahorodnii 2021-09-21 07:49:01 UTC
> 5. go to General Behavior KCM: animation speed slider is still adjusted to instant animation

The animation speed is no longer instant after step 4, but the animation speed slider is also not at "instant". What's the value of the XDG_CURRENT_DESKTOP environment variable?
Comment 2 Patrick Silva 2021-09-21 11:56:32 UTC
(In reply to Vlad Zahorodnii from comment #1)
> > 5. go to General Behavior KCM: animation speed slider is still adjusted to instant animation
> 
> The animation speed is no longer instant after step 4, but the animation
> speed slider is also not at "instant".

I can confirm your observation on neon unstable. On this system the animation speed resets to default value after applying default compositor settings and later changes in animation speed are applied as expected. I will test Arch later.
Comment 3 Patrick Silva 2021-09-21 15:01:04 UTC
(In reply to Vlad Zahorodnii from comment #1)
> XDG_CURRENT_DESKTOP environment variable?
There is no XDG_CURRENT_DESKTOP environment variable on my Arch Linux.
There is XDG_SESSION_DESKTOP instead.

$env
alias systemctl='systemctl -l'
SHELL=/bin/bash
SESSION_MANAGER=local/Arch-PC:@/tmp/.ICE-unix/675,unix/Arch-PC:/tmp/.ICE-unix/675
WINDOWID=1
COLORTERM=truecolor
XDG_CONFIG_DIRS=/home/stalker/.config/kdedefaults:/etc/xdg
GDK_DPI_SCALE=1
XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session1
LANGUAGE=en_US:pt_BR
FREETYPE_PROPERTIES=truetype:interpreter-version=40
DOTNET_ROOT=/usr/share/dotnet
SHELL_SESSION_ID=28b62b7ef6474c88bfe8e1ef268cf84a
DESKTOP_SESSION=plasmawayland
GTK_RC_FILES=/etc/gtk/gtkrc:/home/stalker/.gtkrc:/home/stalker/.config/gtkrc
XCURSOR_SIZE=24
XDG_SEAT=seat0
PWD=/home/stalker
XDG_SESSION_DESKTOP=KDE
LOGNAME=stalker
XDG_SESSION_TYPE=wayland
SYSTEMD_EXEC_PID=721
XAUTHORITY=/run/user/1003/xauth_YYKmvQ
MOTD_SHOWN=pam
GTK2_RC_FILES=/etc/gtk-2.0/gtkrc:/home/stalker/.gtkrc-2.0:/home/stalker/.config/gtkrc-2.0
HOME=/home/stalker
LANG=pt_BR.UTF-8
XDG_CURRENT_DESKTOP=KDE
KONSOLE_DBUS_SERVICE=:1.75
WAYLAND_DISPLAY=wayland-0
KONSOLE_DBUS_SESSION=/Sessions/1
PROFILEHOME=
XDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0
INVOCATION_ID=a8350e466c784398a9b3f91395ba54ba
KONSOLE_VERSION=210801
MANAGERPID=623
DOTNET_BUNDLE_EXTRACT_BASE_DIR=/home/stalker/.cache/dotnet_bundle_extract
KDE_SESSION_UID=1003
XDG_ACTIVATION_TOKEN=Arch-PC;1632236229;599164;721_TIME0
XDG_SESSION_CLASS=user
TERM=xterm-256color
GTK_OVERLAY_SCROLLING=0
USER=stalker
COLORFGBG=15;0
PLASMA_USE_QT_SCALING=1
KDE_SESSION_VERSION=5
PAM_KWALLET5_LOGIN=/run/user/1003/kwallet5.socket
QT_WAYLAND_FORCE_DPI=96
DISPLAY=:1
SHLVL=1
XDG_VTNR=2
XDG_SESSION_ID=2
MOZ_PLUGIN_PATH=/usr/lib/mozilla/plugins
XDG_RUNTIME_DIR=/run/user/1003
QT_AUTO_SCREEN_SCALE_FACTOR=0
JOURNAL_STREAM=8:20767
XCURSOR_THEME=breeze_cursors
XDG_DATA_DIRS=/home/stalker/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/share:/var/lib/snapd/desktop
KDE_FULL_SESSION=true
PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/home/stalker/.dotnet/tools:/home/stalker/.local/share/flatpak/exports/bin:/var/lib/flatpak/exports/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/var/lib/snapd/snap/bin
GDK_SCALE=1
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1003/bus
KDE_APPLICATIONS_AS_SCOPE=1
HG=/usr/bin/hg
MAIL=/var/spool/mail/stalker
_JAVA_OPTIONS=-Dawt.useSystemAAFontSettings=on
KONSOLE_DBUS_WINDOW=/Windows/1
_=/usr/bin/env
Comment 4 Patrick Silva 2021-09-21 15:18:27 UTC
Ops, there is XDG_CURRENT_DESKTOP on my system. Sorry for my mistake.

I was using kwin built from source because I tested a patch to fix bug 442520.
I have just reinstalled kwin 5.23 beta from Arch repos and now the slider is no longer set to instant after reverting compositor settings to defaults. The slider moves to its default position instead.

The only issue here is animation speed reverting to default together compositor settings. I'm not sure if this behavior is intentional or not though.
Comment 5 Bug Janitor Service 2021-09-22 11:38:24 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1449
Comment 6 Nate Graham 2021-09-22 15:10:12 UTC
Git commit 0b9597975170983f04885d617840013fd9b74e83 by Nate Graham, on behalf of Vlad Zahorodnii.
Committed on 22/09/2021 at 15:09.
Pushed by ngraham into branch 'master'.

kcm/compositing: Don't reset animation speed to default value when running in plasma

When running in plasma, the animation speed slider is in General
Behavior KCM.

The Defaults button should not reset the animation speed slider because
it's hidden.

M  +8    -4    src/kcmkwin/kwincompositing/main.cpp

https://invent.kde.org/plasma/kwin/commit/0b9597975170983f04885d617840013fd9b74e83
Comment 7 Nate Graham 2021-09-22 15:10:33 UTC
Git commit 0fc950c13d9b7c2079b9e88fe93d52d497b8a270 by Nate Graham, on behalf of Vlad Zahorodnii.
Committed on 22/09/2021 at 15:10.
Pushed by ngraham into branch 'Plasma/5.23'.

kcm/compositing: Don't reset animation speed to default value when running in plasma

When running in plasma, the animation speed slider is in General
Behavior KCM.

The Defaults button should not reset the animation speed slider because
it's hidden.


(cherry picked from commit 0b9597975170983f04885d617840013fd9b74e83)

M  +8    -4    src/kcmkwin/kwincompositing/main.cpp

https://invent.kde.org/plasma/kwin/commit/0fc950c13d9b7c2079b9e88fe93d52d497b8a270