Bug 442457 - Save/discard/cancel close document dialog now defaults to Cancel
Summary: Save/discard/cancel close document dialog now defaults to Cancel
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kwidgetsaddons
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Christoph Feck
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-09-14 23:43 UTC by Ahmad Samir
Modified: 2021-09-16 19:00 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kwidgetsaddons/commit/8845da411bc3dc86a5135cbd3e3846680d148f88
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Samir 2021-09-14 23:43:57 UTC 
- open kate, type some text
- Ctrl + w, the dialog used to default to "Save", now defaults to "Cancel"

Might be related to this change in KWidgetsAddons: https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/54d85c9898f9f23084b4bd47e262e712385aca30
Comment 1 Nate Graham 2021-09-15 14:17:29 UTC 
Yup, caused by https://invent.kde.org/frameworks/kwidgetsaddons/-/merge_requests/82.
Comment 2 Nate Graham 2021-09-16 19:00:01 UTC 
Git commit 8845da411bc3dc86a5135cbd3e3846680d148f88 by Nate Graham.
Committed on 16/09/2021 at 18:57.
Pushed by ngraham into branch 'master'.

Revert "Set default buttons"

This reverts commit 54d85c9898f9f23084b4bd47e262e712385aca30.

With a heavy heart, we have to revert this for now because various apps
were relying on the previous implicit assignment of default buttons, and
setting them here breaks people's muscle memory and introduces incorrect
behavior changes, such as making "Cancel" the default button in a
"Save/Don't Save/Cancel" dialog. We can revisit the situation in KF6
when it becomes okay to make breaking changes because apps are expected
to have to adapt to them.

M  +0    -9    src/kmessagebox.cpp

https://invent.kde.org/frameworks/kwidgetsaddons/commit/8845da411bc3dc86a5135cbd3e3846680d148f88