SUMMARY Dockers that use the KisUtilityTitlebar (KisAnimTimelineDocker, KisAnimCurvesDocker) no longer maintain an appropriate minimum size and shrink too small. This is a regression. linux git master
Regression caused by commit a6d750785207aacc5bbe493c9351e6ab50b66339 : I've attached a picture of what it looks like. We do need the dockers to respect a minimum size so that the toolbars don't get squashed together. While bug 441761 was fixed with the original commit, there must be another way to resolve this issue without allowing the user to resize the docker to unusable sizes.
Created attachment 141535 [details] Screenshot of problem Here's a screen-capture of the problem.
Hello! Yes, it does make everything look ugly and unusable. But because the bug exists in the Qt's dock widget, there isn't a proper solution which won't involve patching QDockWidget. The two workarounds, I could come up with (after reverting the said commit): 1. We place the titlebar in a QScrollArea and then if the widget is resized, user can scroll. 2. We prevent the Onion Skins docker from displaying docked, if we find the space for it is too little to be shown. This will also fix the problem (besides locking the docking mechanism) where it awkwardly cuts part of the timeline/curves docker (Screenshot of the problem: https://i.imgur.com/OntLvdl.png). What do you think would be more suitable? I personally think 2 seems better.
Hey sh_zam, We would really prefer to do something that doesn't negatively affect the desktop experience. If a work-around needs to happen, we should consider doing it using platform specific defines. My main concern is ensuring that the animation dockers are consistent with other dockers in the desktop version and don't visually break.
Git commit 3388a06fecd6d8e4084cb62c7cb274da5b52da15 by Sharaf Zaman. Committed on 21/09/2021 at 12:16. Pushed by szaman into branch 'master'. Revert "Bugfix: Dockers cannot be attached when mainwindow is small" This reverts commit a6d750785207aacc5bbe493c9351e6ab50b66339. Related: bug 441761 M +0 -5 libs/ui/widgets/kis_utility_title_bar.cpp M +1 -2 libs/ui/widgets/kis_utility_title_bar.h https://invent.kde.org/graphics/krita/commit/3388a06fecd6d8e4084cb62c7cb274da5b52da15
I have reverted the patch. Sadly, there isn't a way to workaround this which doesn't involve ugly hard coding. I tried to make the Onion Skins docker `floating`, if there isn't enough space. But since we don't have a way of knowing if the neighboring docker will shrink or not, we cannot make this work for all cases.
That's unfortunate to hear, but understandable. We could perhaps consider removing the onion skin docker on android (or what we could call 'embedded systems') in favor of a toggle-able widget that serves the same purpose that can be hidden/shown using the onion skin button. Lastly, if it's really the width, I could try to look into making the animation dockers slightly more flexible in future versions for the limited width of android screens. What type of resolution / dpi scaling seems common with android devices? Anyway, I think we should open up bug 441761 again and continue discussion there. Worst case scenario, we could always try to resolve the problem upstream with QT.