Bug 442381 - Bookmark annotation "Insert custom name for the annotation"
Summary: Bookmark annotation "Insert custom name for the annotation"
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 20.12.2
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-13 12:48 UTC by SarenT
Modified: 2021-09-21 20:49 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SarenT 2021-09-13 12:48:42 UTC
SUMMARY
Whenever I annotate something with (e.g. highlighter), okular asks for a custom name for this annotation. This is really annoying from user experience point of view, as I would like to continuously highlight text, without having to rename each highlight. On my Ubuntu Okular doesn't do this (v.1.3.3).

STEPS TO REPRODUCE
1. Open any PDF with text.
2. Select yellow highlighter in quick annotations dropdown box.
3. Hit enter to not give a name and highlight any text.

OBSERVED RESULT
Okular asks for a custom name after each highlight.

EXPECTED RESULT
Okular shouldn't ask for a custom name, or at least provide an option not to.

SOFTWARE/OS VERSIONS
Windows 10 pro

ADDITIONAL INFORMATION
Comment 1 David Hurka 2021-09-15 11:20:57 UTC
> Whenever I annotate something with (e.g. highlighter), okular asks for a custom name for this annotation.

This should usually not happen.

What is your “Author” name in Settings -> Configure Okular... -> Annotations? Okular should fill this in with your user name automatically. If that does not work, it might ask you directly as soon as it is needed.

Can you provide a screenshot of how Okular asks for a name?
Comment 2 SarenT 2021-09-17 13:33:29 UTC
(In reply to David Hurka from comment #1)
> > Whenever I annotate something with (e.g. highlighter), okular asks for a custom name for this annotation.
> 
> This should usually not happen.
> 
> What is your “Author” name in Settings -> Configure Okular... ->
> Annotations? Okular should fill this in with your user name automatically.
> If that does not work, it might ask you directly as soon as it is needed.
> 
> Can you provide a screenshot of how Okular asks for a name?

Hi David,

you are right. After setting the author name, which was blank before, it is no longer asking for a "custom name". I think that dialog could be more informative. I didn't realize that it was asking for the author name. I thought that it wanted to name each annotation.

Thanks!
Comment 3 Albert Astals Cid 2021-09-20 21:21:06 UTC
We need to at least improve that text since it doesn't make any sense.
Comment 4 Bug Janitor Service 2021-09-20 21:27:27 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/484
Comment 5 Albert Astals Cid 2021-09-21 20:49:18 UTC
Git commit 6d52b045dd6aaafd137deb23c15d2f87cf0f4b1e by Albert Astals Cid.
Committed on 20/09/2021 at 21:27.
Pushed by aacid into branch 'master'.

Improve dialog text when asking for annotation author name

The previous texts were totally wrong

M  +1    -1    part/pageviewannotator.cpp

https://invent.kde.org/graphics/okular/commit/6d52b045dd6aaafd137deb23c15d2f87cf0f4b1e